# RPM spec file broken by README.md

4 messages from 2016-04-01 to 2016-04-01. Participants: Ron Isaacson, Matthieu Moy, Christian Couder.
Thread: https://gitlist.dev/t/41895

## Ron Isaacson, 2016-04-01 05:35

Subject: RPM spec file broken by README.md
Message-ID: <CADrzLrOaeQXjWeCnZSJfWWyfr3kzgm59QvR6SeTiw_E2Xg7ugQ@mail.gmail.com>
URL: https://gitlist.dev/e/CADrzLrOaeQXjWeCnZSJfWWyfr3kzgm59QvR6SeTiw_E2Xg7ugQ%40mail.gmail.com

```
Hi everyone,

I've noticed that "make rpm" is failing for 2.8.0 because README was
replaced with README.md. This line in git.spec is the culprit:

%doc README COPYING Documentation/*.txt

Would it be possible to change this to README.md to match the source
tree? The rpm packages build just fine with that change. Thank you
very much!

  - Ron

```

## Matthieu Moy, 2016-04-01 07:10

Subject: [PATCH] git.spec: use README.md, not README
Message-ID: <1459494651-32618-1-git-send-email-Matthieu.Moy@imag.fr>
URL: https://gitlist.dev/e/1459494651-32618-1-git-send-email-Matthieu.Moy%40imag.fr
In-Reply-To: <CADrzLrOaeQXjWeCnZSJfWWyfr3kzgm59QvR6SeTiw_E2Xg7ugQ@mail.gmail.com>

```
The file was renamed in 4ad21f5 (README: use markdown syntax,
2016-02-25), but that commit forgot to update git.spec.in.

Reported-by: Ron Isaacson <isaacson.ljits@gmail.com>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 git.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git.spec.in b/git.spec.in
index d61d537..bfd1cfb 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -146,7 +146,7 @@ rm -rf $RPM_BUILD_ROOT
 %files -f bin-man-doc-files
 %defattr(-,root,root)
 %{_datadir}/git-core/
-%doc README COPYING Documentation/*.txt
+%doc README.md COPYING Documentation/*.txt
 %{!?_without_docs: %doc Documentation/*.html Documentation/howto}
 %{!?_without_docs: %doc Documentation/technical}
 %{_sysconfdir}/bash_completion.d
-- 
2.7.2.334.g35ed2ae.dirty

```

## Christian Couder, 2016-04-01 11:23

Subject: Re: RPM spec file broken by README.md
Message-ID: <CAP8UFD101cKKMcTOxARnWkoNWp-waUMo3B4RH+Co9D9fkpQdfg@mail.gmail.com>
URL: https://gitlist.dev/e/CAP8UFD101cKKMcTOxARnWkoNWp-waUMo3B4RH%2BCo9D9fkpQdfg%40mail.gmail.com
In-Reply-To: <CADrzLrOaeQXjWeCnZSJfWWyfr3kzgm59QvR6SeTiw_E2Xg7ugQ@mail.gmail.com>

```
Hi!

On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <isaacson.ljits@gmail.com> wrote:
> Hi everyone,
>
> I've noticed that "make rpm" is failing for 2.8.0 because README was
> replaced with README.md. This line in git.spec is the culprit:
>
> %doc README COPYING Documentation/*.txt
>
> Would it be possible to change this to README.md to match the source
> tree? The rpm packages build just fine with that change. Thank you
> very much!

Thanks for this bug report.

Would you care to send a patch?

```

## Christian Couder, 2016-04-01 11:24

Subject: Re: RPM spec file broken by README.md
Message-ID: <CAP8UFD0xFj9CxYtqsdMz9ug_eTf0y+9eEEJ7r2r8og3XBAevTQ@mail.gmail.com>
URL: https://gitlist.dev/e/CAP8UFD0xFj9CxYtqsdMz9ug_eTf0y%2B9eEEJ7r2r8og3XBAevTQ%40mail.gmail.com
In-Reply-To: <CAP8UFD101cKKMcTOxARnWkoNWp-waUMo3B4RH+Co9D9fkpQdfg@mail.gmail.com>

```
On Fri, Apr 1, 2016 at 1:23 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> Hi!
>
> On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <isaacson.ljits@gmail.com> wrote:
>> Hi everyone,
>>
>> I've noticed that "make rpm" is failing for 2.8.0 because README was
>> replaced with README.md. This line in git.spec is the culprit:
>>
>> %doc README COPYING Documentation/*.txt
>>
>> Would it be possible to change this to README.md to match the source
>> tree? The rpm packages build just fine with that change. Thank you
>> very much!
>
> Thanks for this bug report.
>
> Would you care to send a patch?

Ooops, it looks like Matthieu already sent a patch. Sorry for the noise.

```