threads / discuss / 40676
Subject: Anonymous commit (empty Author and Committer)
See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
I was not even aware that this is possible. Is there anything on server side that can prevent it?
Would be good if commit were amended and force pushed to fix it.
Re: Anonymous commit (empty Author and Committer)
On Fri, 30 Oct 2015 17:26:00 +0300 Andrei Borzenkov <arvidjaar@gmail.com> wrote:
> See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on > server side that can prevent it?
A hook running on "update" event could check the commits being pushed and reject the update if some commit among those does not pass the necessary checks.
Please see the githooks(5) manual page.
Jeff KingRe: Anonymous commit (empty Author and Committer)
On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote:
> See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on server side > that can prevent it?
I would have thought that receive.fsckObjects would reject it, but seems that git-fsck does not complain about it at all, as it is otherwise syntactically valid (a space separating the zero-length name from the email, and <> surrounding the empty email).
We do complain during "git commit" about an empty name. We don't seem to do so for blank emails, though. The only discussion I could find mentions that should probably disallow both[1].
I wonder how this commit was created in the first place (through git-commit, and we have an empty-name case that is not covered, or using a lower-level tool that bypasses the checks).
-Peff
[1] http://article.gmane.org/gmane.comp.version-control.git/261237
Re: [Savannah-users] Anonymous commit (empty Author and Committer)
> > See > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc3 > 19df14cd3398fbdfde665ac > > > > > > > > > > I was not even aware that this is possible. Is there anything on > > server side that can prevent it? > > > > Would be good if commit were amended and force pushed to fix it. > > > > > > Is this even a problem? I'm pretty sure Git warns you if you try to > commit something before user.name and user.email are defined, and if > someone wants to do so, I don't see why you should try to stop them. > It wouldn't work, anyway; they would just write some simple name like > "anonymous" and some nonsense email if they really want to be anonymous. >
This commit just removed a line from the README:
"Please look at the GRUB Wiki <http://grub.enbug.org> for testing-procedures."
Is this change something that may justify that it's-not-me-there action? I agree that it should not be prevented to avoid some pressure situations that might be (eventually) present. Bogus random data there would be harder to track. The empty fields are easy, and if it guarantees some safety to whoever does it, should be the choice.
-- http://www.fastmail.com - mmm... Fastmail...
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 15:26, Andrei Borzenkov wrote: >> See >> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >> >> >> I was not even aware that this is possible. Is there anything on server >> side that can prevent it? >> >> Would be good if commit were amended and force pushed to fix it. >> > It is a bug in SGit. I'll investigate how it happened >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> . >> > >
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>> See >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >>> >>> >>> I was not even aware that this is possible. Is there anything on server >>> side that can prevent it? >>> >>> Would be good if commit were amended and force pushed to fix it. >>> >> It is a bug in SGit. I'll investigate how it happened
I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit?
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> On 30.10.2015 15:26, Andrei Borzenkov wrote: > >>> See > >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > >>> > >>> > >>> I was not even aware that this is possible. Is there anything on server > >>> side that can prevent it? > >>> > >>> Would be good if commit were amended and force pushed to fix it. > >>> > >> It is a bug in SGit. I'll investigate how it happened > > I don't have non-fast-forward rights. Does someone from savannah-users > have them? Could he just delete this commit?
If you do that, then anyone that already did a pull after it went in will have a broken tree. Rather annoying.
-- Len Sorensen _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 13:59, Lennart Sorensen wrote:
>> I don't have non-fast-forward rights. Does someone from savannah-users >> have them? Could he just delete this commit? > > If you do that, then anyone that already did a pull after it went in > will have a broken tree. Rather annoying.
Nope. They will have a git in which that commit looks like their own local work. *Someone* will inadvertently do a "git push" to blast out their changes based on that deleted commit, thereby causing it to reappear.
:)
Andreas SchwabRe: Anonymous commit (empty Author and Committer)
Kaz Kylheku <kaz@kylheku.com> writes:
> Nope. They will have a git in which that commit looks like their own > local work. *Someone* will inadvertently do a "git push" to blast out > their changes based on that deleted commit, thereby causing it to > reappear.
Not if another one pushes something different in the mean time.
Andreas.
-- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Re: Anonymous commit (empty Author and Committer)
31.10.2015 10:02, Andreas Schwab пишет:
> Kaz Kylheku <kaz@kylheku.com> writes: > >> Nope. They will have a git in which that commit looks like their own >> local work. *Someone* will inadvertently do a "git push" to blast out >> their changes based on that deleted commit, thereby causing it to >> reappear. > > Not if another one pushes something different in the mean time. >
Which is why I said "amended".
Re: Anonymous commit (empty Author and Committer)
30.10.2015 23:59, Lennart Sorensen пишет:
> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>>> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>>>> See >>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >>>>> >>>>> >>>>> I was not even aware that this is possible. Is there anything on server >>>>> side that can prevent it? >>>>> >>>>> Would be good if commit were amended and force pushed to fix it. >>>>> >>>> It is a bug in SGit. I'll investigate how it happened >> >> I don't have non-fast-forward rights. Does someone from savannah-users >> have them? Could he just delete this commit? > > If you do that, then anyone that already did a pull after it went in > will have a broken tree. Rather annoying. >
If we decide to fix this commit it is better done now, while it is the last one. It is annoying but do you have suggestion how it can be done differently?
Re: Anonymous commit (empty Author and Committer)
On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:
> If we decide to fix this commit it is better done now, while it is the last > one. It is annoying but do you have suggestion how it can be done > differently?
Well the only options are:
1) Leave it alone 2) Break the tree of anyone that already pulled. (Posting instructions on how to fix it would at least be nice then).
Not sure how many people regularly pull the tree.
-- Len Sorensen
Re: [Savannah-users] Anonymous commit (empty Author and Committer)
On 02.11.2015 07:11, Lennart Sorensen wrote:
> On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote: >> If we decide to fix this commit it is better done now, while it is the >> last >> one. It is annoying but do you have suggestion how it can be done >> differently? > > Well the only options are: > > 1) Leave it alone > 2) Break the tree of anyone that already pulled. (Posting instructions > on > how to fix it would at least be nice then). > > Not sure how many people regularly pull the tree.
This is silly FUD. There is no ever any "broken tree".
Firstly, people who have no local changes do not experience any ill effect. They just have to do
$ git fetch
# oops, upstream and local branch have diverged # but I have absolutely no local work to preserve; # just "warp" HEAD to the new one:
$ git reset --hard origin/master
# done!
Those who have outstanding local work never have any expectation of non-breakage! *All* fetches are "non-fast-forward" with regard to unpublished local work, because they occur to a prior version of the work, underneath your changes.
In *all* cases you can do this:
# Fast-forward or not, I don't care! $ git fetch
# Take my 13 unpublished commits (or whatever number), rebase them over the # latest upstream master, and make the result my local master branch:
$ git rebase HEAD~13 --onto origin/master
Junio C HamanoRe: Anonymous commit (empty Author and Committer)
"Lennart Sorensen" <lsorense@csclub.uwaterloo.ca> writes:
> On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote: >> If we decide to fix this commit it is better done now, while it is the last >> one. It is annoying but do you have suggestion how it can be done >> differently? > > Well the only options are: > > 1) Leave it alone > 2) Break the tree of anyone that already pulled. (Posting instructions on > how to fix it would at least be nice then). > > Not sure how many people regularly pull the tree.
Is the discussion still require attention by Git folks for their help? If not, could you take this back to savannah specific mailing list?
Thanks.
Re: Anonymous commit (empty Author and Committer)
30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет:
> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>>> See >>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >>>> >>>> >>>> I was not even aware that this is possible. Is there anything on server >>>> side that can prevent it? >>>> >>>> Would be good if commit were amended and force pushed to fix it. >>>> >>> It is a bug in SGit. I'll investigate how it happened > > I don't have non-fast-forward rights. Does someone from savannah-users > have them? Could he just delete this commit?
Looking at mail archives, non-fast-forward is global repository property and disabled by default. We probably need to open Savannah ticket to get it temporary enabled.