{"thread":{"id":"40676","subject":"Anonymous commit (empty Author and Committer)","startedAt":"2015-10-30T14:26:00Z","lastAt":"2015-11-02T16:42:41Z","messageCount":15,"participants":["Andrei Borzenkov","Konstantin Khomoutov","Balaco Baco","Jeff King","Vladimir 'φ-coder/phcoder' Serbinenko","Lennart Sorensen","Kaz Kylheku","Andreas Schwab","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"272525","messageId":"56337DF8.5050802@gmail.com","threadId":"40676","inReplyTo":null,"subject":"Anonymous commit (empty Author and Committer)","fromName":"Andrei Borzenkov","fromEmail":"arvidjaar@gmail.com","sentAt":"2015-10-30T14:26:00Z","receivedAt":"2015-10-30T14:26:00Z","isPatch":false,"sender":{"key":"arvidjaar@gmail.com","avatar":null},"body":"See \nhttp://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n\nI was not even aware that this is possible. Is there anything on server \nside that can prevent it?\n\nWould be good if commit were amended and force pushed to fix it.\n"},{"id":"272526","messageId":"20151030173304.b199c558199149fea057dc86@domain007.com","threadId":"40676","inReplyTo":"56337DF8.5050802@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2015-10-30T14:33:04Z","receivedAt":"2015-10-30T14:33:04Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Fri, 30 Oct 2015 17:26:00 +0300\nAndrei Borzenkov wrote:\n\n> See \n> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n> \n> I was not even aware that this is possible. Is there anything on\n> server side that can prevent it?\n\nA hook running on \"update\" event could check the commits being pushed\nand reject the update if some commit among those does not pass the\nnecessary checks.\n\nPlease see the githooks(5) manual page.\n"},{"id":"272528","messageId":"1446219582.3019364.424715177.39046D65@webmail.messagingengine.com","threadId":"40676","inReplyTo":"56338C30.6010302@riseup.net","subject":"Re: [Savannah-users] Anonymous commit (empty Author and Committer)","fromName":"Balaco Baco","fromEmail":"balacobaco@imap.cc","sentAt":"2015-10-30T15:39:42Z","receivedAt":"2015-10-30T15:39:42Z","isPatch":false,"sender":{"key":"balacobaco@imap.cc","avatar":null},"body":"\n> > See \n> > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc3\n> 19df14cd3398fbdfde665ac\n> >\n> >\n> > \n> > \n> > I was not even aware that this is possible. Is there anything on \n> > server side that can prevent it?\n> > \n> > Would be good if commit were amended and force pushed to fix it.\n> > \n> > \n> \n> Is this even a problem? I'm pretty sure Git warns you if you try to\n> commit something before user.name and user.email are defined, and if\n> someone wants to do so, I don't see why you should try to stop them.\n> It wouldn't work, anyway; they would just write some simple name like\n> \"anonymous\" and some nonsense email if they really want to be anonymous.\n> \n\nThis commit just removed a line from the README:\n\n\"Please look at the GRUB Wiki for\ntesting-procedures.\"\n\nIs this change something that may justify that it's-not-me-there action?\nI agree that it should not be prevented to avoid some pressure\nsituations that might be (eventually) present. Bogus random data there\nwould be harder to track. The empty fields are easy, and if it\nguarantees some safety to whoever does it, should be the choice.\n\n\n-- \nhttp://www.fastmail.com - mmm... Fastmail...\n"},{"id":"272533","messageId":"20151030170102.GA32384@sigill.intra.peff.net","threadId":"40676","inReplyTo":"56337DF8.5050802@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-10-30T17:01:03Z","receivedAt":"2015-10-30T17:01:03Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote:\n\n> See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n> \n> I was not even aware that this is possible. Is there anything on server side\n> that can prevent it?\n\nI would have thought that receive.fsckObjects would reject it, but seems\nthat git-fsck does not complain about it at all, as it is otherwise\nsyntactically valid (a space separating the zero-length name from the\nemail, and <> surrounding the empty email).\n\nWe do complain during \"git commit\" about an empty name. We don't seem to\ndo so for blank emails, though. The only discussion I could find\nmentions that should probably disallow both[1].\n\nI wonder how this commit was created in the first place (through\ngit-commit, and we have an empty-name case that is not covered, or using\na lower-level tool that bypasses the checks).\n\n-Peff\n\n[1] http://article.gmane.org/gmane.comp.version-control.git/261237\n"},{"id":"272575","messageId":"5633CE60.8060907@gmail.com","threadId":"40676","inReplyTo":"5633CDCD.10004@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Vladimir 'φ-coder/phcoder' Serbinenko","fromEmail":"phcoder@gmail.com","sentAt":"2015-10-30T20:09:04Z","receivedAt":"2015-10-30T20:09:04Z","isPatch":false,"sender":{"key":"phcoder@gmail.com","avatar":null},"body":"On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n> On 30.10.2015 15:26, Andrei Borzenkov wrote:\n>> See\n>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n>>\n>>\n>> I was not even aware that this is possible. Is there anything on server\n>> side that can prevent it?\n>>\n>> Would be good if commit were amended and force pushed to fix it.\n>>\n> It is a bug in SGit. I'll investigate how it happened\n>> _______________________________________________\n>> Grub-devel mailing list\n>> Grub-devel@gnu.org\n>> https://lists.gnu.org/mailman/listinfo/grub-devel\n>> .\n>>\n> \n> \n\n\n"},{"id":"272576","messageId":"5633D0C7.2020709@gmail.com","threadId":"40676","inReplyTo":"5633CE60.8060907@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Vladimir 'φ-coder/phcoder' Serbinenko","fromEmail":"phcoder@gmail.com","sentAt":"2015-10-30T20:19:19Z","receivedAt":"2015-10-30T20:19:19Z","isPatch":false,"sender":{"key":"phcoder@gmail.com","avatar":null},"body":"On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>> On 30.10.2015 15:26, Andrei Borzenkov wrote:\n>>> See\n>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n>>>\n>>>\n>>> I was not even aware that this is possible. Is there anything on server\n>>> side that can prevent it?\n>>>\n>>> Would be good if commit were amended and force pushed to fix it.\n>>>\n>> It is a bug in SGit. I'll investigate how it happened\n\nI don't have non-fast-forward rights. Does someone from savannah-users\nhave them? Could he just delete this commit?\n\n\n\n\n_______________________________________________\nGrub-devel mailing list\nGrub-devel@gnu.org\nhttps://lists.gnu.org/mailman/listinfo/grub-devel\n"},{"id":"272578","messageId":"20151030205955.GC21923@csclub.uwaterloo.ca","threadId":"40676","inReplyTo":"5633D0C7.2020709@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Lennart Sorensen","fromEmail":"lsorense@csclub.uwaterloo.ca","sentAt":"2015-10-30T20:59:55Z","receivedAt":"2015-10-30T20:59:55Z","isPatch":false,"sender":{"key":"lsorense@csclub.uwaterloo.ca","avatar":null},"body":"On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n> > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n> >> On 30.10.2015 15:26, Andrei Borzenkov wrote:\n> >>> See\n> >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n> >>>\n> >>>\n> >>> I was not even aware that this is possible. Is there anything on server\n> >>> side that can prevent it?\n> >>>\n> >>> Would be good if commit were amended and force pushed to fix it.\n> >>>\n> >> It is a bug in SGit. I'll investigate how it happened\n> \n> I don't have non-fast-forward rights. Does someone from savannah-users\n> have them? Could he just delete this commit?\n\nIf you do that, then anyone that already did a pull after it went in\nwill have a broken tree. Rather annoying.\n\n-- \nLen Sorensen\n\n_______________________________________________\nGrub-devel mailing list\nGrub-devel@gnu.org\nhttps://lists.gnu.org/mailman/listinfo/grub-devel\n"},{"id":"272584","messageId":"0eb2d04aed9a93b38867292bfa6c55f6@mail.kylheku.com","threadId":"40676","inReplyTo":"20151030205955.GC21923@csclub.uwaterloo.ca","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Kaz Kylheku","fromEmail":"kaz@kylheku.com","sentAt":"2015-10-30T21:45:24Z","receivedAt":"2015-10-30T21:45:24Z","isPatch":false,"sender":{"key":"kaz@kylheku.com","avatar":null},"body":"On 30.10.2015 13:59, Lennart Sorensen wrote:\n>> I don't have non-fast-forward rights. Does someone from savannah-users\n>> have them? Could he just delete this commit?\n> \n> If you do that, then anyone that already did a pull after it went in\n> will have a broken tree. Rather annoying.\n\nNope. They will have a git in which that commit looks like their own\nlocal work. *Someone* will inadvertently do a \"git push\" to blast out\ntheir changes based on that deleted commit, thereby causing it to\nreappear.\n\n:)\n"},{"id":"272604","messageId":"56345076.30207@gmail.com","threadId":"40676","inReplyTo":"20151030205955.GC21923@csclub.uwaterloo.ca","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Andrei Borzenkov","fromEmail":"arvidjaar@gmail.com","sentAt":"2015-10-31T05:24:06Z","receivedAt":"2015-10-31T05:24:06Z","isPatch":false,"sender":{"key":"arvidjaar@gmail.com","avatar":null},"body":"30.10.2015 23:59, Lennart Sorensen пишет:\n> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>>>> On 30.10.2015 15:26, Andrei Borzenkov wrote:\n>>>>> See\n>>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n>>>>>\n>>>>>\n>>>>> I was not even aware that this is possible. Is there anything on server\n>>>>> side that can prevent it?\n>>>>>\n>>>>> Would be good if commit were amended and force pushed to fix it.\n>>>>>\n>>>> It is a bug in SGit. I'll investigate how it happened\n>>\n>> I don't have non-fast-forward rights. Does someone from savannah-users\n>> have them? Could he just delete this commit?\n>\n> If you do that, then anyone that already did a pull after it went in\n> will have a broken tree. Rather annoying.\n>\n\nIf we decide to fix this commit it is better done now, while it is the \nlast one. It is annoying but do you have suggestion how it can be done \ndifferently?\n"},{"id":"272606","messageId":"871tcbwmf0.fsf@igel.home","threadId":"40676","inReplyTo":"0eb2d04aed9a93b38867292bfa6c55f6@mail.kylheku.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2015-10-31T07:02:27Z","receivedAt":"2015-10-31T07:02:27Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Kaz Kylheku writes:\n\n> Nope. They will have a git in which that commit looks like their own\n> local work. *Someone* will inadvertently do a \"git push\" to blast out\n> their changes based on that deleted commit, thereby causing it to\n> reappear.\n\nNot if another one pushes something different in the mean time.\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"272616","messageId":"5634C63F.8050702@gmail.com","threadId":"40676","inReplyTo":"871tcbwmf0.fsf@igel.home","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Andrei Borzenkov","fromEmail":"arvidjaar@gmail.com","sentAt":"2015-10-31T13:46:39Z","receivedAt":"2015-10-31T13:46:39Z","isPatch":false,"sender":{"key":"arvidjaar@gmail.com","avatar":null},"body":"31.10.2015 10:02, Andreas Schwab пишет:\n> Kaz Kylheku writes:\n>\n>> Nope. They will have a git in which that commit looks like their own\n>> local work. *Someone* will inadvertently do a \"git push\" to blast out\n>> their changes based on that deleted commit, thereby causing it to\n>> reappear.\n>\n> Not if another one pushes something different in the mean time.\n>\n\nWhich is why I said \"amended\".\n"},{"id":"272618","messageId":"5634C809.2070608@gmail.com","threadId":"40676","inReplyTo":"5633D0C7.2020709@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Andrei Borzenkov","fromEmail":"arvidjaar@gmail.com","sentAt":"2015-10-31T13:54:17Z","receivedAt":"2015-10-31T13:54:17Z","isPatch":false,"sender":{"key":"arvidjaar@gmail.com","avatar":null},"body":"30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет:\n> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:\n>>> On 30.10.2015 15:26, Andrei Borzenkov wrote:\n>>>> See\n>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac\n>>>>\n>>>>\n>>>> I was not even aware that this is possible. Is there anything on server\n>>>> side that can prevent it?\n>>>>\n>>>> Would be good if commit were amended and force pushed to fix it.\n>>>>\n>>> It is a bug in SGit. I'll investigate how it happened\n>\n> I don't have non-fast-forward rights. Does someone from savannah-users\n> have them? Could he just delete this commit?\n\nLooking at mail archives, non-fast-forward is global repository property \nand disabled by default. We probably need to open Savannah ticket to get \nit temporary enabled.\n"},{"id":"272731","messageId":"20151102151123.GF21923@csclub.uwaterloo.ca","threadId":"40676","inReplyTo":"56345076.30207@gmail.com","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Lennart Sorensen","fromEmail":"lsorense@csclub.uwaterloo.ca","sentAt":"2015-11-02T15:11:23Z","receivedAt":"2015-11-02T15:11:23Z","isPatch":false,"sender":{"key":"lsorense@csclub.uwaterloo.ca","avatar":null},"body":"On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:\n> If we decide to fix this commit it is better done now, while it is the last\n> one. It is annoying but do you have suggestion how it can be done\n> differently?\n\nWell the only options are:\n\n1) Leave it alone\n2) Break the tree of anyone that already pulled. (Posting instructions on\nhow to fix it would at least be nice then).\n\nNot sure how many people regularly pull the tree.\n\n-- \nLen Sorensen\n"},{"id":"272734","messageId":"4da05191ce7780bed3a0e00f25b09bc9@mail.kylheku.com","threadId":"40676","inReplyTo":"20151102151123.GF21923@csclub.uwaterloo.ca","subject":"Re: [Savannah-users] Anonymous commit (empty Author and Committer)","fromName":"Kaz Kylheku","fromEmail":"kaz@kylheku.com","sentAt":"2015-11-02T16:37:00Z","receivedAt":"2015-11-02T16:37:00Z","isPatch":false,"sender":{"key":"kaz@kylheku.com","avatar":null},"body":"On 02.11.2015 07:11, Lennart Sorensen wrote:\n> On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:\n>> If we decide to fix this commit it is better done now, while it is the \n>> last\n>> one. It is annoying but do you have suggestion how it can be done\n>> differently?\n> \n> Well the only options are:\n> \n> 1) Leave it alone\n> 2) Break the tree of anyone that already pulled. (Posting instructions \n> on\n> how to fix it would at least be nice then).\n> \n> Not sure how many people regularly pull the tree.\n\nThis is silly FUD. There is no ever any \"broken tree\".\n\nFirstly, people who have no local changes do not experience any ill \neffect.\nThey just have to do\n\n $ git fetch\n\n # oops, upstream and local branch have diverged\n # but I have absolutely no local work to preserve;\n # just \"warp\" HEAD to the new one:\n\n $ git reset --hard origin/master\n\n # done!\n\nThose who have outstanding local work never have any expectation of \nnon-breakage!\n*All* fetches are \"non-fast-forward\" with regard to unpublished\nlocal work, because they occur to a prior version of the work, \nunderneath your\nchanges.\n\nIn *all* cases you can do this:\n\n # Fast-forward or not, I don't care!\n $ git fetch\n\n # Take my 13 unpublished commits (or whatever number), rebase them \nover the\n # latest upstream master, and make the result my local master branch:\n\n $ git rebase HEAD~13 --onto origin/master\n"},{"id":"272735","messageId":"xmqq37wofj3y.fsf@gitster.mtv.corp.google.com","threadId":"40676","inReplyTo":"20151102151123.GF21923@csclub.uwaterloo.ca","subject":"Re: Anonymous commit (empty Author and Committer)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-11-02T16:42:41Z","receivedAt":"2015-11-02T16:42:41Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Lennart Sorensen\" writes:\n\n> On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:\n>> If we decide to fix this commit it is better done now, while it is the last\n>> one. It is annoying but do you have suggestion how it can be done\n>> differently?\n>\n> Well the only options are:\n>\n> 1) Leave it alone\n> 2) Break the tree of anyone that already pulled. (Posting instructions on\n> how to fix it would at least be nice then).\n>\n> Not sure how many people regularly pull the tree.\n\nIs the discussion still require attention by Git folks for their\nhelp? If not, could you take this back to savannah specific mailing\nlist?\n\nThanks.\n"}]}