threads / patch / 40512

v2, 2 partsquote: fix broken sq_quote_buf() related comment

Subject: [PATCH v2 1/2] quote: fix broken sq_quote_buf() related comment

## tl;dr

3 messages between Oct 7, 2015 and Oct 7, 2015. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Christian Couder· Oct 7, 2015, 22:05 UTC · lore

Since 77d604c (Enhanced sq_quote(), 10 Oct 2005), the comment at the beginning of quote.c is broken. Let's fix it.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
The only change in this v2 is the added Signed-off-by ;-)
Sorry for the spam.
 quote.c | 1 +
 1 file changed, 1 insertion(+)
Show changes to quote.c +1 −0
diff --git a/quote.c b/quote.c
index 7920e18..890885a 100644
--- a/quote.c
+++ b/quote.c
@@ -7,6 +7,7 @@ int quote_path_fully = 1;
 /* Help to copy the thing properly quoted for the shell safety.
  * any single quote is replaced with '\'', any exclamation point
  * is replaced with '\!', and the whole thing is enclosed in a
+ * single quote pair.
  *
  * E.g.
  *  original     sq_quote     result

-- 
2.6.0
Christian Couder· Oct 7, 2015, 22:05 UTC · re: Christian Couder · lore

[PATCH v2 2/2] quote: move comment before sq_quote_buf()

A big comment at the beginning of quote.c is really related to sq_quote_buf(), so let's move it in front of this function.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 quote.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Show changes to quote.c +5 −5
diff --git a/quote.c b/quote.c
index 890885a..fe884d2 100644
--- a/quote.c
+++ b/quote.c
@@ -4,6 +4,11 @@
 
 int quote_path_fully = 1;
 
+static inline int need_bs_quote(char c)
+{
+	return (c == '\'' || c == '!');
+}
+
 /* Help to copy the thing properly quoted for the shell safety.
  * any single quote is replaced with '\'', any exclamation point
  * is replaced with '\!', and the whole thing is enclosed in a
@@ -16,11 +21,6 @@ int quote_path_fully = 1;
  *  a'b      ==> a'\''b    ==> 'a'\''b'
  *  a!b      ==> a'\!'b    ==> 'a'\!'b'
  */
-static inline int need_bs_quote(char c)
-{
-	return (c == '\'' || c == '!');
-}
-
 void sq_quote_buf(struct strbuf *dst, const char *src)
 {
 	char *to_free = NULL;

-- 
2.6.0

← back to recent threads