# [PATCH v2 1/2] quote: fix broken sq_quote_buf() related comment 3 messages from 2015-10-07 to 2015-10-07. Participants: Christian Couder, Junio C Hamano. Thread: https://gitlist.dev/t/40512 ## Christian Couder, 2015-10-07 22:05 Subject: [PATCH v2 1/2] quote: fix broken sq_quote_buf() related comment Message-ID: <1444255550-27631-1-git-send-email-chriscool@tuxfamily.org> URL: https://gitlist.dev/e/1444255550-27631-1-git-send-email-chriscool%40tuxfamily.org ``` Since 77d604c (Enhanced sq_quote(), 10 Oct 2005), the comment at the beginning of quote.c is broken. Let's fix it. Signed-off-by: Christian Couder --- The only change in this v2 is the added Signed-off-by ;-) Sorry for the spam. quote.c | 1 + 1 file changed, 1 insertion(+) diff --git a/quote.c b/quote.c index 7920e18..890885a 100644 --- a/quote.c +++ b/quote.c @@ -7,6 +7,7 @@ int quote_path_fully = 1; /* Help to copy the thing properly quoted for the shell safety. * any single quote is replaced with '\'', any exclamation point * is replaced with '\!', and the whole thing is enclosed in a + * single quote pair. * * E.g. * original sq_quote result -- 2.6.0 ``` ## Christian Couder, 2015-10-07 22:05 Subject: [PATCH v2 2/2] quote: move comment before sq_quote_buf() Message-ID: <1444255550-27631-2-git-send-email-chriscool@tuxfamily.org> URL: https://gitlist.dev/e/1444255550-27631-2-git-send-email-chriscool%40tuxfamily.org In-Reply-To: <1444255550-27631-1-git-send-email-chriscool@tuxfamily.org> ``` A big comment at the beginning of quote.c is really related to sq_quote_buf(), so let's move it in front of this function. Signed-off-by: Christian Couder --- quote.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/quote.c b/quote.c index 890885a..fe884d2 100644 --- a/quote.c +++ b/quote.c @@ -4,6 +4,11 @@ int quote_path_fully = 1; +static inline int need_bs_quote(char c) +{ + return (c == '\'' || c == '!'); +} + /* Help to copy the thing properly quoted for the shell safety. * any single quote is replaced with '\'', any exclamation point * is replaced with '\!', and the whole thing is enclosed in a @@ -16,11 +21,6 @@ int quote_path_fully = 1; * a'b ==> a'\''b ==> 'a'\''b' * a!b ==> a'\!'b ==> 'a'\!'b' */ -static inline int need_bs_quote(char c) -{ - return (c == '\'' || c == '!'); -} - void sq_quote_buf(struct strbuf *dst, const char *src) { char *to_free = NULL; -- 2.6.0 ``` ## Junio C Hamano, 2015-10-07 22:46 Subject: Re: [PATCH v2 2/2] quote: move comment before sq_quote_buf() Message-ID: URL: https://gitlist.dev/e/xmqqoagas3dq.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1444255550-27631-2-git-send-email-chriscool@tuxfamily.org> ``` Thanks, will queue. ```