threads / bug / 40305

Bug report: GIT PRO/Branches chapter

Subject: Bug report: GIT PRO/Branches chapter

## tl;dr

4 messages between Sep 9, 2015 and Sep 9, 2015.

replies: 3people: 3as markdown or json

Robert Macháček· Sep 9, 2015, 06:11 UTC · lore

Hi,

Just reading this chapter: https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell

I believe that: Figure 3-9. Divergent history (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png) does not show the final "2 branch situation" as described in the example in this chapter. On the picture, the master and testing branch do not point to correct commit hashes in the picture. I was thinking for a while why they are swapped and the only conclusion I made is that it's simply a bug in the picture as it also does not correspond to the correct git log output in the chapter.

$ git log --oneline --decorate --graph --all
* c2b9e (HEAD, master) made other changes
| * 87ab2 (testing) made a change

I suggest to fix the picture or clarify the reason in the chapter.

Hope it helps, Robert

Johannes Schindelin· Sep 9, 2015, 08:08 UTC · re: Robert Macháček · lore

Re: Bug report: GIT PRO/Branches chapter

Hi Robert,

On 2015-09-09 08:11, Robert Macháček wrote:

Show 7 quoted lines

> Just reading this chapter:
> https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell
> 
> I believe that: Figure 3-9. Divergent history
> (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png)
> does not show the final "2 branch situation" as described in the
> example in this chapter.

I guess you want to report it here:

    https://github.com/progit/progit2/issues

(as suggested by the link on the left side of the page you referred to, where it says: "The source of this book is hosted on GitHub. Patches, suggestions and comments are welcome.")

You might want to search the tickets first, though, to make sure that it has not been reported before (or even already addressed).

Ciao, Johannes

Robert Macháček· Sep 9, 2015, 08:16 UTC · re: Johannes Schindelin · lore

Re: Bug report: GIT PRO/Branches chapter

Hi Johannes,

Sorry, I am new to git, I have just followed instructions at https://git-scm.com/community which says:

Mailing List Questions or comments for the Git community can be sent to the mailing list by using the email address git@vger.kernel.org. Bug reports should be sent to this mailing list.

The last sentence is made with BOLD font and I assumed that this applies to the book as well as it is hosted on this domain (so what other bugs are they talking about BTW?)

I'll have a look to github*/issues as you've suggested.

Thanks, Robert

On Wed, Sep 9, 2015 at 3:08 PM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 22 quoted lines

> Hi Robert,
>
> On 2015-09-09 08:11, Robert Macháček wrote:
>
>> Just reading this chapter:
>> https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell
>>
>> I believe that: Figure 3-9. Divergent history
>> (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png)
>> does not show the final "2 branch situation" as described in the
>> example in this chapter.
>
> I guess you want to report it here:
>
>     https://github.com/progit/progit2/issues
>
> (as suggested by the link on the left side of the page you referred to, where it says: "The source of this book is hosted on GitHub. Patches, suggestions and comments are welcome.")
>
> You might want to search the tickets first, though, to make sure that it has not been reported before (or even already addressed).
>
> Ciao,
> Johannes

Jeff King· Sep 9, 2015, 09:16 UTC · re: Robert Macháček · lore

Re: Bug report: GIT PRO/Branches chapter

On Wed, Sep 09, 2015 at 03:16:38PM +0700, Robert Macháček wrote:

Show 11 quoted lines

> Sorry, I am new to git, I have just followed instructions at
> https://git-scm.com/community which says:
> 
> Mailing List
> Questions or comments for the Git community can be sent to the mailing
> list by using the email address git@vger.kernel.org. Bug reports
> should be sent to this mailing list.
> 
> The last sentence is made with BOLD font and I assumed that this
> applies to the book as well as it is hosted on this domain (so what
> other bugs are they talking about BTW?)

Sorry, it _is_ confusing. The page you showed is about bugs in git itself. The website and the book are maintained separately, and bug reporting should go to their issue trackers. Of course it doesn't actually say that anywhere. :)

I've just opened https://github.com/git/git-scm.com/pull/590 to improve this.

-Peff