{"thread":{"id":"40305","subject":"Bug report: GIT PRO/Branches chapter","startedAt":"2015-09-09T06:11:46Z","lastAt":"2015-09-09T09:16:46Z","messageCount":4,"participants":["Robert Macháček","Johannes Schindelin","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"269635","messageId":"CACwN7xFG0RrCZCZiUb=h-x2svV3B6Q1U5b3=3x6r08ZZM3mPmg@mail.gmail.com","threadId":"40305","inReplyTo":null,"subject":"Bug report: GIT PRO/Branches chapter","fromName":"Robert Macháček","fromEmail":"lighthunt.net@gmail.com","sentAt":"2015-09-09T06:11:46Z","receivedAt":"2015-09-09T06:11:46Z","isPatch":false,"sender":{"key":"lighthunt.net@gmail.com","avatar":null},"body":"Hi,\n\nJust reading this chapter:\nhttps://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell\n\nI believe that: Figure 3-9. Divergent history\n(https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png)\ndoes not show the final \"2 branch situation\" as described in the\nexample in this chapter. On the picture, the master and testing branch\ndo not point to correct commit hashes in the picture. I was thinking\nfor a while why they are swapped and the only conclusion I made is\nthat it's simply a bug in the picture as it also does not correspond\nto the correct git log output in the chapter.\n\n$ git log --oneline --decorate --graph --all\n* c2b9e (HEAD, master) made other changes\n| * 87ab2 (testing) made a change\n\nI suggest to fix the picture or clarify the reason in the chapter.\n\nHope it helps,\nRobert\n"},{"id":"269638","messageId":"9039e46ed0bc66aec7b30c24183acdb0@dscho.org","threadId":"40305","inReplyTo":"CACwN7xFG0RrCZCZiUb=h-x2svV3B6Q1U5b3=3x6r08ZZM3mPmg@mail.gmail.com","subject":"Re: Bug report: GIT PRO/Branches chapter","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-09-09T08:08:10Z","receivedAt":"2015-09-09T08:08:10Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Robert,\n\nOn 2015-09-09 08:11, Robert Macháček wrote:\n\n> Just reading this chapter:\n> https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell\n> \n> I believe that: Figure 3-9. Divergent history\n> (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png)\n> does not show the final \"2 branch situation\" as described in the\n> example in this chapter.\n\nI guess you want to report it here:\n\n https://github.com/progit/progit2/issues\n\n(as suggested by the link on the left side of the page you referred to, where it says: \"The source of this book is hosted on GitHub. Patches, suggestions and comments are welcome.\")\n\nYou might want to search the tickets first, though, to make sure that it has not been reported before (or even already addressed).\n\nCiao,\nJohannes\n"},{"id":"269639","messageId":"CACwN7xFU4yFeh=RPmPk4kwKBL5WjTB7pBY8RFFFNgf+k-a_Q4w@mail.gmail.com","threadId":"40305","inReplyTo":"9039e46ed0bc66aec7b30c24183acdb0@dscho.org","subject":"Re: Bug report: GIT PRO/Branches chapter","fromName":"Robert Macháček","fromEmail":"lighthunt.net@gmail.com","sentAt":"2015-09-09T08:16:38Z","receivedAt":"2015-09-09T08:16:38Z","isPatch":false,"sender":{"key":"lighthunt.net@gmail.com","avatar":null},"body":"Hi Johannes,\n\nSorry, I am new to git, I have just followed instructions at\nhttps://git-scm.com/community which says:\n\nMailing List\nQuestions or comments for the Git community can be sent to the mailing\nlist by using the email address git@vger.kernel.org. Bug reports\nshould be sent to this mailing list.\n\nThe last sentence is made with BOLD font and I assumed that this\napplies to the book as well as it is hosted on this domain (so what\nother bugs are they talking about BTW?)\n\nI'll have a look to github*/issues as you've suggested.\n\nThanks,\nRobert\n\n\nOn Wed, Sep 9, 2015 at 3:08 PM, Johannes Schindelin\n wrote:\n> Hi Robert,\n>\n> On 2015-09-09 08:11, Robert Macháček wrote:\n>\n>> Just reading this chapter:\n>> https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell\n>>\n>> I believe that: Figure 3-9. Divergent history\n>> (https://git-scm.com/book/en/v2/book/03-git-branching/images/advance-master.png)\n>> does not show the final \"2 branch situation\" as described in the\n>> example in this chapter.\n>\n> I guess you want to report it here:\n>\n> https://github.com/progit/progit2/issues\n>\n> (as suggested by the link on the left side of the page you referred to, where it says: \"The source of this book is hosted on GitHub. Patches, suggestions and comments are welcome.\")\n>\n> You might want to search the tickets first, though, to make sure that it has not been reported before (or even already addressed).\n>\n> Ciao,\n> Johannes\n"},{"id":"269643","messageId":"20150909091646.GB21892@sigill.intra.peff.net","threadId":"40305","inReplyTo":"CACwN7xFU4yFeh=RPmPk4kwKBL5WjTB7pBY8RFFFNgf+k-a_Q4w@mail.gmail.com","subject":"Re: Bug report: GIT PRO/Branches chapter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-09-09T09:16:46Z","receivedAt":"2015-09-09T09:16:46Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Sep 09, 2015 at 03:16:38PM +0700, Robert Macháček wrote:\n\n> Sorry, I am new to git, I have just followed instructions at\n> https://git-scm.com/community which says:\n> \n> Mailing List\n> Questions or comments for the Git community can be sent to the mailing\n> list by using the email address git@vger.kernel.org. Bug reports\n> should be sent to this mailing list.\n> \n> The last sentence is made with BOLD font and I assumed that this\n> applies to the book as well as it is hosted on this domain (so what\n> other bugs are they talking about BTW?)\n\nSorry, it _is_ confusing. The page you showed is about bugs in git\nitself. The website and the book are maintained separately, and bug\nreporting should go to their issue trackers. Of course it doesn't\nactually say that anywhere. :)\n\nI've just opened https://github.com/git/git-scm.com/pull/590 to improve\nthis.\n\n-Peff\n"}]}