threads / patch / 40061

patcht2019: skip test requiring '*' in a file name non Windows

Subject: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

## tl;dr

4 messages between Aug 11, 2015 and Aug 13, 2015. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Johannes Sixt· Aug 11, 2015, 20:38 UTC · lore

A test case introduced by ae454f61 (Add tests for wildcard "path vs ref" disambiguation) allocates a file named '*.c'. This does not work on Windows, because the OS forbids file names containing wildcard characters. The test case fails where the shell attempts to allocate the file. Skip the test on Windows.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 This fixes a new failure in the test suite (t3404.8[67]) on Windows, but
 I got around to debug it only now.

 t/t2019-checkout-ambiguous-ref.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t2019-checkout-ambiguous-ref.sh +1 −1

diff --git a/t/t2019-checkout-ambiguous-ref.sh b/t/t2019-checkout-ambiguous-ref.sh
index 8396320..199b22d 100755
--- a/t/t2019-checkout-ambiguous-ref.sh
+++ b/t/t2019-checkout-ambiguous-ref.sh
@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '
 	)
 '
 
-test_expect_success 'wildcard ambiguation, refs lose' '
+test_expect_success !MINGW 'wildcard ambiguation, refs lose' '
 	git init ambi2 &&
 	(
 		cd ambi2 &&

-- 
2.3.2.245.gb5bf9d3

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Johannes Schindelin· Aug 12, 2015, 11:25 UTC · re: Johannes Sixt · lore

Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

Hi,

On 2015-08-11 22:38, Johannes Sixt wrote:

Show 14 quoted lines

> diff --git a/t/t2019-checkout-ambiguous-ref.sh
> b/t/t2019-checkout-ambiguous-ref.sh
> index 8396320..199b22d 100755
> --- a/t/t2019-checkout-ambiguous-ref.sh
> +++ b/t/t2019-checkout-ambiguous-ref.sh
> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '
>  	)
>  '
>  
> -test_expect_success 'wildcard ambiguation, refs lose' '
> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '
>  	git init ambi2 &&
>  	(
>  		cd ambi2 &&

FWIW I planned to submit a patch including this fix:

https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c

(The idea of the `fixup! ` was to make this change part of a larger change during the next merging rebase of Git for Windows.)

Ciao, Johannes

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Junio C Hamano· Aug 12, 2015, 16:28 UTC · re: Johannes Schindelin · lore

Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 25 quoted lines

> Hi,
>
> On 2015-08-11 22:38, Johannes Sixt wrote:
>
>> diff --git a/t/t2019-checkout-ambiguous-ref.sh
>> b/t/t2019-checkout-ambiguous-ref.sh
>> index 8396320..199b22d 100755
>> --- a/t/t2019-checkout-ambiguous-ref.sh
>> +++ b/t/t2019-checkout-ambiguous-ref.sh
>> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '
>>  	)
>>  '
>>  
>> -test_expect_success 'wildcard ambiguation, refs lose' '
>> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '
>>  	git init ambi2 &&
>>  	(
>>  		cd ambi2 &&
>
> FWIW I planned to submit a patch including this fix:
>
> https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c
>
> (The idea of the `fixup! ` was to make this change part of a larger
> change during the next merging rebase of Git for Windows.)

Thanks.  Is that an Ack?

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Johannes Schindelin· Aug 13, 2015, 08:30 UTC · re: Junio C Hamano · lore

Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows

Hi Junio,

On 2015-08-12 18:28, Junio C Hamano wrote:

Show 27 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> On 2015-08-11 22:38, Johannes Sixt wrote:
>>
>>> diff --git a/t/t2019-checkout-ambiguous-ref.sh
>>> b/t/t2019-checkout-ambiguous-ref.sh
>>> index 8396320..199b22d 100755
>>> --- a/t/t2019-checkout-ambiguous-ref.sh
>>> +++ b/t/t2019-checkout-ambiguous-ref.sh
>>> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '
>>>  	)
>>>  '
>>>
>>> -test_expect_success 'wildcard ambiguation, refs lose' '
>>> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '
>>>  	git init ambi2 &&
>>>  	(
>>>  		cd ambi2 &&
>>
>> FWIW I planned to submit a patch including this fix:
>>
>> https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c
>>
>> (The idea of the `fixup! ` was to make this change part of a larger
>> change during the next merging rebase of Git for Windows.)
> 
> Thanks.  Is that an Ack?

Yes, this is an Ack. (Although I would have preferred to organize the contribution of Windows-related patches better, really.)

Ciao, Dscho

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.