{"thread":{"id":"40061","subject":"[PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows","startedAt":"2015-08-11T20:38:46Z","lastAt":"2015-08-13T08:30:08Z","messageCount":4,"participants":["Johannes Sixt","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"267860","messageId":"55CA5D56.6030800@kdbg.org","threadId":"40061","inReplyTo":null,"subject":"[PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2015-08-11T20:38:46Z","receivedAt":"2015-08-11T20:38:46Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"A test case introduced by ae454f61 (Add tests for wildcard \"path vs ref\"\ndisambiguation) allocates a file named '*.c'. This does not work on\nWindows, because the OS forbids file names containing wildcard\ncharacters. The test case fails where the shell attempts to allocate the\nfile. Skip the test on Windows.\n\nSigned-off-by: Johannes Sixt \n---\n This fixes a new failure in the test suite (t3404.8[67]) on Windows, but\n I got around to debug it only now.\n\n t/t2019-checkout-ambiguous-ref.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t2019-checkout-ambiguous-ref.sh b/t/t2019-checkout-ambiguous-ref.sh\nindex 8396320..199b22d 100755\n--- a/t/t2019-checkout-ambiguous-ref.sh\n+++ b/t/t2019-checkout-ambiguous-ref.sh\n@@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '\n \t)\n '\n \n-test_expect_success 'wildcard ambiguation, refs lose' '\n+test_expect_success !MINGW 'wildcard ambiguation, refs lose' '\n \tgit init ambi2 &&\n \t(\n \t\tcd ambi2 &&\n-- \n2.3.2.245.gb5bf9d3\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"267897","messageId":"a9e3c007fb6b39e7339c8d2b1c50d56b@www.dscho.org","threadId":"40061","inReplyTo":"55CA5D56.6030800@kdbg.org","subject":"Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-08-12T11:25:54Z","receivedAt":"2015-08-12T11:25:54Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn 2015-08-11 22:38, Johannes Sixt wrote:\n\n> diff --git a/t/t2019-checkout-ambiguous-ref.sh\n> b/t/t2019-checkout-ambiguous-ref.sh\n> index 8396320..199b22d 100755\n> --- a/t/t2019-checkout-ambiguous-ref.sh\n> +++ b/t/t2019-checkout-ambiguous-ref.sh\n> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '\n> \t)\n> '\n> \n> -test_expect_success 'wildcard ambiguation, refs lose' '\n> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '\n> \tgit init ambi2 &&\n> \t(\n> \t\tcd ambi2 &&\n\nFWIW I planned to submit a patch including this fix:\n\nhttps://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c\n\n(The idea of the `fixup! ` was to make this change part of a larger change during the next merging rebase of Git for Windows.)\n\nCiao,\nJohannes\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"267916","messageId":"xmqqbnecmpyc.fsf@gitster.dls.corp.google.com","threadId":"40061","inReplyTo":"a9e3c007fb6b39e7339c8d2b1c50d56b@www.dscho.org","subject":"Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-08-12T16:28:11Z","receivedAt":"2015-08-12T16:28:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On 2015-08-11 22:38, Johannes Sixt wrote:\n>\n>> diff --git a/t/t2019-checkout-ambiguous-ref.sh\n>> b/t/t2019-checkout-ambiguous-ref.sh\n>> index 8396320..199b22d 100755\n>> --- a/t/t2019-checkout-ambiguous-ref.sh\n>> +++ b/t/t2019-checkout-ambiguous-ref.sh\n>> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '\n>> \t)\n>> '\n>> \n>> -test_expect_success 'wildcard ambiguation, refs lose' '\n>> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '\n>> \tgit init ambi2 &&\n>> \t(\n>> \t\tcd ambi2 &&\n>\n> FWIW I planned to submit a patch including this fix:\n>\n> https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c\n>\n> (The idea of the `fixup! ` was to make this change part of a larger\n> change during the next merging rebase of Git for Windows.)\n\nThanks. Is that an Ack?\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"267972","messageId":"3a67b9f0c21518c9e3d8e2d33bbfd2ee@www.dscho.org","threadId":"40061","inReplyTo":"xmqqbnecmpyc.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH nd/dwim-wildcards-as-pathspecs] t2019: skip test requiring '*' in a file name non Windows","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-08-13T08:30:08Z","receivedAt":"2015-08-13T08:30:08Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn 2015-08-12 18:28, Junio C Hamano wrote:\n> Johannes Schindelin writes:\n> \n>> On 2015-08-11 22:38, Johannes Sixt wrote:\n>>\n>>> diff --git a/t/t2019-checkout-ambiguous-ref.sh\n>>> b/t/t2019-checkout-ambiguous-ref.sh\n>>> index 8396320..199b22d 100755\n>>> --- a/t/t2019-checkout-ambiguous-ref.sh\n>>> +++ b/t/t2019-checkout-ambiguous-ref.sh\n>>> @@ -69,7 +69,7 @@ test_expect_success 'wildcard ambiguation, paths win' '\n>>> \t)\n>>> '\n>>>\n>>> -test_expect_success 'wildcard ambiguation, refs lose' '\n>>> +test_expect_success !MINGW 'wildcard ambiguation, refs lose' '\n>>> \tgit init ambi2 &&\n>>> \t(\n>>> \t\tcd ambi2 &&\n>>\n>> FWIW I planned to submit a patch including this fix:\n>>\n>> https://github.com/git-for-windows/git/commit/4694320330e1b4d9178e13e215ce60a1cc8e0b1c\n>>\n>> (The idea of the `fixup! ` was to make this change part of a larger\n>> change during the next merging rebase of Git for Windows.)\n> \n> Thanks. Is that an Ack?\n\nYes, this is an Ack. (Although I would have preferred to organize the contribution of Windows-related patches better, really.)\n\nCiao,\nDscho\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"Git for Windows\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"}]}