threads / patch / 39964

patchref-filter: fix indentation

Subject: [PATCH] ref-filter: fix indentation

## tl;dr

4 messages between Jul 29, 2015 and Jul 29, 2015. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Matthieu Moy· Jul 29, 2015, 15:52 UTC · lore
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
This is meant to be applied on top of kn/for-each-ref.
 ref-filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to ref-filter.c +2 −2
diff --git a/ref-filter.c b/ref-filter.c
index 43502a4..3fbbbeb 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
 	struct ref_array_item *ref;
 
 	if (flag & REF_BAD_NAME) {
-		  warning("ignoring ref with broken name %s", refname);
-		  return 0;
+		warning("ignoring ref with broken name %s", refname);
+		return 0;
 	}
 
 	if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))
-- 
2.5.0.rc0.7.ge1edd74.dirty
Karthik Nayak· Jul 29, 2015, 16:11 UTC · re: Matthieu Moy · lore

Re: [PATCH] ref-filter: fix indentation

On Wed, Jul 29, 2015 at 9:22 PM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
Show 29 quoted lines
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> This is meant to be applied on top of kn/for-each-ref.
>
>  ref-filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index 43502a4..3fbbbeb 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
>         struct ref_array_item *ref;
>
>         if (flag & REF_BAD_NAME) {
> -                 warning("ignoring ref with broken name %s", refname);
> -                 return 0;
> +               warning("ignoring ref with broken name %s", refname);
> +               return 0;
>         }
>
>         if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))
> --
> 2.5.0.rc0.7.ge1edd74.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thanks for this :)
-- 
Regards,
Karthik Nayak
Junio C Hamano· Jul 29, 2015, 17:49 UTC · re: Matthieu Moy · lore

Re: [PATCH] ref-filter: fix indentation

Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> This is meant to be applied on top of kn/for-each-ref.

Hmm, as 2.5 is already out and we can rewind 'next' in the coming couple of days, I am tempted to squash this in instead of applying it on top.

Thanks.
Show 18 quoted lines
>  ref-filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index 43502a4..3fbbbeb 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
>  	struct ref_array_item *ref;
>  
>  	if (flag & REF_BAD_NAME) {
> -		  warning("ignoring ref with broken name %s", refname);
> -		  return 0;
> +		warning("ignoring ref with broken name %s", refname);
> +		return 0;
>  	}
>  
>  	if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))
Matthieu Moy· Jul 29, 2015, 21:18 UTC · re: Junio C Hamano · lore

Re: [PATCH] ref-filter: fix indentation

Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>> ---
>> This is meant to be applied on top of kn/for-each-ref.
>
> Hmm, as 2.5 is already out and we can rewind 'next' in the coming
> couple of days, I am tempted to squash this in instead of applying
> it on top.
Perfect.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

← back to recent threads