{"thread":{"id":"39964","subject":"[PATCH] ref-filter: fix indentation","startedAt":"2015-07-29T15:52:30Z","lastAt":"2015-07-29T21:18:00Z","messageCount":4,"participants":["Matthieu Moy","Karthik Nayak","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"267058","messageId":"1438185150-31730-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"39964","inReplyTo":null,"subject":"[PATCH] ref-filter: fix indentation","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2015-07-29T15:52:30Z","receivedAt":"2015-07-29T15:52:30Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Signed-off-by: Matthieu Moy \n---\nThis is meant to be applied on top of kn/for-each-ref.\n\n ref-filter.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/ref-filter.c b/ref-filter.c\nindex 43502a4..3fbbbeb 100644\n--- a/ref-filter.c\n+++ b/ref-filter.c\n@@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,\n \tstruct ref_array_item *ref;\n \n \tif (flag & REF_BAD_NAME) {\n-\t\t warning(\"ignoring ref with broken name %s\", refname);\n-\t\t return 0;\n+\t\twarning(\"ignoring ref with broken name %s\", refname);\n+\t\treturn 0;\n \t}\n \n \tif (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))\n-- \n2.5.0.rc0.7.ge1edd74.dirty\n"},{"id":"267067","messageId":"CAOLa=ZQf+_BkvjFC4Fv=X8_3A=KAs7e4JB2CZC3n5U6yffSLpg@mail.gmail.com","threadId":"39964","inReplyTo":"1438185150-31730-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] ref-filter: fix indentation","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2015-07-29T16:11:11Z","receivedAt":"2015-07-29T16:11:11Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"On Wed, Jul 29, 2015 at 9:22 PM, Matthieu Moy wrote:\n> Signed-off-by: Matthieu Moy \n> ---\n> This is meant to be applied on top of kn/for-each-ref.\n>\n> ref-filter.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/ref-filter.c b/ref-filter.c\n> index 43502a4..3fbbbeb 100644\n> --- a/ref-filter.c\n> +++ b/ref-filter.c\n> @@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,\n> struct ref_array_item *ref;\n>\n> if (flag & REF_BAD_NAME) {\n> - warning(\"ignoring ref with broken name %s\", refname);\n> - return 0;\n> + warning(\"ignoring ref with broken name %s\", refname);\n> + return 0;\n> }\n>\n> if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))\n> --\n> 2.5.0.rc0.7.ge1edd74.dirty\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\nThanks for this :)\n\n-- \nRegards,\nKarthik Nayak\n"},{"id":"267076","messageId":"xmqq3806am76.fsf@gitster.dls.corp.google.com","threadId":"39964","inReplyTo":"1438185150-31730-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] ref-filter: fix indentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-07-29T17:49:17Z","receivedAt":"2015-07-29T17:49:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Signed-off-by: Matthieu Moy \n> ---\n> This is meant to be applied on top of kn/for-each-ref.\n\nHmm, as 2.5 is already out and we can rewind 'next' in the coming\ncouple of days, I am tempted to squash this in instead of applying\nit on top.\n\nThanks.\n\n> ref-filter.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/ref-filter.c b/ref-filter.c\n> index 43502a4..3fbbbeb 100644\n> --- a/ref-filter.c\n> +++ b/ref-filter.c\n> @@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,\n> \tstruct ref_array_item *ref;\n> \n> \tif (flag & REF_BAD_NAME) {\n> -\t\t warning(\"ignoring ref with broken name %s\", refname);\n> -\t\t return 0;\n> +\t\twarning(\"ignoring ref with broken name %s\", refname);\n> +\t\treturn 0;\n> \t}\n> \n> \tif (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))\n"},{"id":"267105","messageId":"vpqmvyeek8n.fsf@anie.imag.fr","threadId":"39964","inReplyTo":"xmqq3806am76.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] ref-filter: fix indentation","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-07-29T21:18:00Z","receivedAt":"2015-07-29T21:18:00Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> Matthieu Moy writes:\n>\n>> Signed-off-by: Matthieu Moy \n>> ---\n>> This is meant to be applied on top of kn/for-each-ref.\n>\n> Hmm, as 2.5 is already out and we can rewind 'next' in the coming\n> couple of days, I am tempted to squash this in instead of applying\n> it on top.\n\nPerfect.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}