threads / patch / 39375

patchclean: remove unused variable buf

Subject: [PATCH] clean: remove unused variable buf

## tl;dr

2 messages between May 19, 2015 and May 30, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

René Scharfe· May 19, 2015, 22:13 UTC · lore

It had never been used.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 builtin/clean.c | 2 --
 1 file changed, 2 deletions(-)

Show changes to builtin/clean.c +0 −2

diff --git a/builtin/clean.c b/builtin/clean.c
index 98c103f..a9eb772 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
 {
 	struct string_list menu_list = STRING_LIST_INIT_DUP;
 	struct strbuf menu = STRBUF_INIT;
-	struct strbuf buf = STRBUF_INIT;
 	struct menu_item *menu_item;
 	struct string_list_item *string_list_item;
 	int i;
@@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
 	pretty_print_menus(&menu_list);
 
 	strbuf_release(&menu);
-	strbuf_release(&buf);
 	string_list_clear(&menu_list, 0);
 }

-- 
2.4.1

Jiang Xin· May 30, 2015, 15:20 UTC · re: René Scharfe · lore

Re: [PATCH] clean: remove unused variable buf

2015-05-20 6:13 GMT+08:00 René Scharfe <l.s.r@web.de>:

> It had never been used.

Confirmed. The unused "buf" should be removed.

Show 29 quoted lines

>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  builtin/clean.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 98c103f..a9eb772 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
>  {
>         struct string_list menu_list = STRING_LIST_INIT_DUP;
>         struct strbuf menu = STRBUF_INIT;
> -       struct strbuf buf = STRBUF_INIT;
>         struct menu_item *menu_item;
>         struct string_list_item *string_list_item;
>         int i;
> @@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
>         pretty_print_menus(&menu_list);
>
>         strbuf_release(&menu);
> -       strbuf_release(&buf);
>         string_list_clear(&menu_list, 0);
>  }
>
> --
> 2.4.1
>

-- 
Jiang Xin