{"thread":{"id":"39375","subject":"[PATCH] clean: remove unused variable buf","startedAt":"2015-05-19T22:13:26Z","lastAt":"2015-05-30T15:20:52Z","messageCount":2,"participants":["René Scharfe","Jiang Xin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"261612","messageId":"555BB586.8050503@web.de","threadId":"39375","inReplyTo":null,"subject":"[PATCH] clean: remove unused variable buf","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2015-05-19T22:13:26Z","receivedAt":"2015-05-19T22:13:26Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"It had never been used.\n\nSigned-off-by: Rene Scharfe <l.s.r@web.de>\n---\n builtin/clean.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/builtin/clean.c b/builtin/clean.c\nindex 98c103f..a9eb772 100644\n--- a/builtin/clean.c\n+++ b/builtin/clean.c\n@@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)\n {\n \tstruct string_list menu_list = STRING_LIST_INIT_DUP;\n \tstruct strbuf menu = STRBUF_INIT;\n-\tstruct strbuf buf = STRBUF_INIT;\n \tstruct menu_item *menu_item;\n \tstruct string_list_item *string_list_item;\n \tint i;\n@@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)\n \tpretty_print_menus(&menu_list);\n \n \tstrbuf_release(&menu);\n-\tstrbuf_release(&buf);\n \tstring_list_clear(&menu_list, 0);\n }\n \n-- \n2.4.1\n"},{"id":"262466","messageId":"CANYiYbEYLGZ00RadktTvEY1cp97ZckkUz++dxi6X7FzyrSn2bg@mail.gmail.com","threadId":"39375","inReplyTo":"555BB586.8050503@web.de","subject":"Re: [PATCH] clean: remove unused variable buf","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2015-05-30T15:20:52Z","receivedAt":"2015-05-30T15:20:52Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"2015-05-20 6:13 GMT+08:00 René Scharfe <l.s.r@web.de>:\n> It had never been used.\n\nConfirmed. The unused \"buf\" should be removed.\n\n>\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n>  builtin/clean.c | 2 --\n>  1 file changed, 2 deletions(-)\n>\n> diff --git a/builtin/clean.c b/builtin/clean.c\n> index 98c103f..a9eb772 100644\n> --- a/builtin/clean.c\n> +++ b/builtin/clean.c\n> @@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)\n>  {\n>         struct string_list menu_list = STRING_LIST_INIT_DUP;\n>         struct strbuf menu = STRBUF_INIT;\n> -       struct strbuf buf = STRBUF_INIT;\n>         struct menu_item *menu_item;\n>         struct string_list_item *string_list_item;\n>         int i;\n> @@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)\n>         pretty_print_menus(&menu_list);\n>\n>         strbuf_release(&menu);\n> -       strbuf_release(&buf);\n>         string_list_clear(&menu_list, 0);\n>  }\n>\n> --\n> 2.4.1\n>\n\n\n\n-- \nJiang Xin\n"}]}