threads / patch / 39252

v2completion: remove credential helpers from porcelain commands

Subject: [PATCH v2] completion: remove credential helpers from porcelain commands

## tl;dr

One message between May 5, 2015 and May 5, 2015. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

SZEDER Gábor· May 5, 2015, 16:33 UTC · lore

Don't offer the "main" 'git credential' command or any of the credential helpers from contrib/credential/ when completing git commands.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
> > +               credential-gnome-keyring) : credentials helpe;;
>
> Typo? Should be "helper;;", no?
Indeed, thanks.
 contrib/completion/git-completion.bash | 5 +++++
 1 file changed, 5 insertions(+)
Show changes to contrib/completion/git-completion.bash +5 −0
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index e0eb6ae..42efbd6 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -665,8 +665,13 @@ __git_list_porcelain_commands ()
 		checkout-index)   : plumbing;;
 		commit-tree)      : plumbing;;
 		count-objects)    : infrequent;;
+		credential        : credentials;;
 		credential-cache) : credentials helper;;
+		credential-gnome-keyring) : credentials helper;;
+		credential-netrc) : credentials helper;;
+		credential-osxkeychain) : credentials helper;;
 		credential-store) : credentials helper;;
+		credential-wincred) : credentials helper;;
 		cvsexportcommit)  : export;;
 		cvsimport)        : import;;
 		cvsserver)        : daemon;;
-- 
1.9.5.msysgit.0

← back to recent threads