{"thread":{"id":"39252","subject":"[PATCH v2] completion: remove credential helpers from porcelain commands","startedAt":"2015-05-05T16:33:13Z","lastAt":"2015-05-05T16:33:13Z","messageCount":1,"participants":["SZEDER Gábor"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"260593","messageId":"1430843593-412-1-git-send-email-szeder@ira.uka.de","threadId":"39252","inReplyTo":null,"subject":"[PATCH v2] completion: remove credential helpers from porcelain commands","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2015-05-05T16:33:13Z","receivedAt":"2015-05-05T16:33:13Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Don't offer the \"main\" 'git credential' command or any of the credential\nhelpers from contrib/credential/ when completing git commands.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n\n> > +               credential-gnome-keyring) : credentials helpe;;\n>\n> Typo? Should be \"helper;;\", no?\n\nIndeed, thanks.\n\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex e0eb6ae..42efbd6 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -665,8 +665,13 @@ __git_list_porcelain_commands ()\n \t\tcheckout-index)   : plumbing;;\n \t\tcommit-tree)      : plumbing;;\n \t\tcount-objects)    : infrequent;;\n+\t\tcredential        : credentials;;\n \t\tcredential-cache) : credentials helper;;\n+\t\tcredential-gnome-keyring) : credentials helper;;\n+\t\tcredential-netrc) : credentials helper;;\n+\t\tcredential-osxkeychain) : credentials helper;;\n \t\tcredential-store) : credentials helper;;\n+\t\tcredential-wincred) : credentials helper;;\n \t\tcvsexportcommit)  : export;;\n \t\tcvsimport)        : import;;\n \t\tcvsserver)        : daemon;;\n-- \n1.9.5.msysgit.0\n"}]}