threads / patch / 38505

patch, 2 partsMakefile: Improve wording in a comment

Subject: [PATCH 1/2] Makefile: Improve wording in a comment

## tl;dr

5 messages between Feb 5, 2015 and Feb 5, 2015. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Sebastian Schuberth· Feb 5, 2015, 13:26 UTC · lore
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Makefile +1 −1
diff --git a/Makefile b/Makefile
index c44eb3a..6f8ae23 100644
--- a/Makefile
+++ b/Makefile
@@ -2447,7 +2447,7 @@ check-docs::
         esac; \
     done ) | sort

-### Make sure built-ins do not have dups and listed in git.c
+### Make sure built-ins do not have dupes and are listed in git.c
 #
 check-builtins::
     ./check-builtins.sh
-- 
2.1.2-mingw-1
Junio C Hamano· Feb 5, 2015, 19:17 UTC · re: Sebastian Schuberth · lore

Re: [PATCH 1/2] Makefile: Improve wording in a comment

Sebastian Schuberth <sschuberth@gmail.com> writes:
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---

Is that an improvement? Is the plural of "dup" (used as an abbreviation of "duplicate") "dupes" not "dups"?

Show 16 quoted lines
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c44eb3a..6f8ae23 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2447,7 +2447,7 @@ check-docs::
>          esac; \
>      done ) | sort
>
> -### Make sure built-ins do not have dups and listed in git.c
> +### Make sure built-ins do not have dupes and are listed in git.c
>  #
>  check-builtins::
>      ./check-builtins.sh
Sebastian Schuberth· Feb 5, 2015, 19:19 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/2] Makefile: Improve wording in a comment

On Thu, Feb 5, 2015 at 8:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Sebastian Schuberth <sschuberth@gmail.com> writes:
>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>> ---
>
> Is that an improvement?  Is the plural of "dup" (used as an
> abbreviation of "duplicate") "dupes" not "dups"?

My view is that the abbreviation of "duplicate" is not "dup" but "dupe", hence the plural "dupes".

-- 
Sebastian Schuberth
Sebastian Schuberth· Feb 5, 2015, 19:22 UTC · re: Sebastian Schuberth · lore

Re: [PATCH 1/2] Makefile: Improve wording in a comment

On Thu, Feb 5, 2015 at 8:19 PM, Sebastian Schuberth <sschuberth@gmail.com> wrote:

Show 5 quoted lines
>> Is that an improvement?  Is the plural of "dup" (used as an
>> abbreviation of "duplicate") "dupes" not "dups"?
>
> My view is that the abbreviation of "duplicate" is not "dup" but
> "dupe", hence the plural "dupes".

For "duplicate" the noun, that is. For "duplicate" the verb I'd be ok with "dup" as the abbreviation. "to dup" sounds and looks better than "to dupe" :-)

-- 
Sebastian Schuberth
Stefan Beller· Feb 5, 2015, 20:04 UTC · re: Sebastian Schuberth · lore

Re: [PATCH 1/2] Makefile: Improve wording in a comment

On Thu, Feb 5, 2015 at 11:22 AM, Sebastian Schuberth <sschuberth@gmail.com> wrote:

Show 13 quoted lines
> On Thu, Feb 5, 2015 at 8:19 PM, Sebastian Schuberth
> <sschuberth@gmail.com> wrote:
>
>>> Is that an improvement?  Is the plural of "dup" (used as an
>>> abbreviation of "duplicate") "dupes" not "dups"?
>>
>> My view is that the abbreviation of "duplicate" is not "dup" but
>> "dupe", hence the plural "dupes".
>
> For "duplicate" the noun, that is. For "duplicate" the verb I'd be ok
> with "dup" as the abbreviation. "to dup" sounds and looks better than
> "to dupe" :-)
>
We could also not abbreviate that word to avoid discussion there.

← back to recent threads