[PATCH v2] init-db: remove unused include

Alexander Kuleshov· Jan 15, 2015, 11:47 UTC · lore

"cache.h" removed, because it's already included at "builtin.h"

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 builtin/init-db.c | 1 -
 1 file changed, 1 deletion(-)

Show changes to builtin/init-db.c +0 −1

diff --git a/builtin/init-db.c b/builtin/init-db.c
index 280454a..8edef87 100644
--- a/builtin/init-db.c
+++ b/builtin/init-db.c
@@ -3,7 +3,6 @@
  *
  * Copyright (C) Linus Torvalds, 2005
  */
-#include "cache.h"
 #include "builtin.h"
 #include "exec_cmd.h"
 #include "parse-options.h"

-- 
2.3.0.rc0.256.g2ad8601.dirty

Junio C Hamano· Jan 15, 2015, 19:11 UTC · re: Alexander Kuleshov · lore

Re: [PATCH v2] init-db: remove unused include

Alexander Kuleshov <kuleshovmail@gmail.com> writes:

> "cache.h" removed, because it's already included at "builtin.h"
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---

Let's put this on hold.

$ git grep --all-match -l -e cache\\.h -e builtin\\.h -- \*.c

shows us there are tons, not just this one.

Also I'd like to see this discussion simmer a bit more:

  http://thread.gmane.org/gmane.comp.version-control.git/262454/focus=262499

Show 15 quoted lines

>  builtin/init-db.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index 280454a..8edef87 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -3,7 +3,6 @@
>   *
>   * Copyright (C) Linus Torvalds, 2005
>   */
> -#include "cache.h"
>  #include "builtin.h"
>  #include "exec_cmd.h"
>  #include "parse-options.h"

v2init-db: remove unused include