{"thread":{"id":"38370","subject":"[PATCH v2] init-db: remove unused include","startedAt":"2015-01-15T11:47:31Z","lastAt":"2015-01-15T19:11:53Z","messageCount":2,"participants":["Alexander Kuleshov","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"254742","messageId":"1421322451-1852-1-git-send-email-kuleshovmail@gmail.com","threadId":"38370","inReplyTo":null,"subject":"[PATCH v2] init-db: remove unused include","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-15T11:47:31Z","receivedAt":"2015-01-15T11:47:31Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"\"cache.h\" removed, because it's already included at \"builtin.h\"\n\nSigned-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>\n---\n builtin/init-db.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/init-db.c b/builtin/init-db.c\nindex 280454a..8edef87 100644\n--- a/builtin/init-db.c\n+++ b/builtin/init-db.c\n@@ -3,7 +3,6 @@\n  *\n  * Copyright (C) Linus Torvalds, 2005\n  */\n-#include \"cache.h\"\n #include \"builtin.h\"\n #include \"exec_cmd.h\"\n #include \"parse-options.h\"\n-- \n2.3.0.rc0.256.g2ad8601.dirty\n"},{"id":"254768","messageId":"xmqqiog77tae.fsf@gitster.dls.corp.google.com","threadId":"38370","inReplyTo":"1421322451-1852-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH v2] init-db: remove unused include","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-15T19:11:53Z","receivedAt":"2015-01-15T19:11:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexander Kuleshov <kuleshovmail@gmail.com> writes:\n\n> \"cache.h\" removed, because it's already included at \"builtin.h\"\n>\n> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>\n> ---\n\nLet's put this on hold.\n\n$ git grep --all-match -l -e cache\\\\.h -e builtin\\\\.h -- \\*.c\n\nshows us there are tons, not just this one.\n\nAlso I'd like to see this discussion simmer a bit more:\n\n  http://thread.gmane.org/gmane.comp.version-control.git/262454/focus=262499\n\n>  builtin/init-db.c | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/builtin/init-db.c b/builtin/init-db.c\n> index 280454a..8edef87 100644\n> --- a/builtin/init-db.c\n> +++ b/builtin/init-db.c\n> @@ -3,7 +3,6 @@\n>   *\n>   * Copyright (C) Linus Torvalds, 2005\n>   */\n> -#include \"cache.h\"\n>  #include \"builtin.h\"\n>  #include \"exec_cmd.h\"\n>  #include \"parse-options.h\"\n"}]}