threads / patch / 38334

patchcat-file: remove unnecessary #include

Subject: [PATCH] cat-file: remove unnecessary #include

## tl;dr

One message between Jan 10, 2015 and Jan 10, 2015. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alexander Kuleshov· Jan 10, 2015, 18:29 UTC · lore
"cache.h" is already included in "builtin.h"

It appeared at e83c51 (Initial revision of "git", the information manager from hell., 8 Apr 2005) and used cache.c API (get_sha1_hex and read_sha1_file). After this in the commit f81dae (Builtin git-cat-file., ) was included "builtin.h", which already includes "cache.h", so we no need to include it in the cat-file.c

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 builtin/cat-file.c | 1 -
 1 file changed, 1 deletion(-)
Show changes to builtin/cat-file.c +0 −1
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 750b5a2..2e6aaa1 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -3,7 +3,6 @@
  *
  * Copyright (C) Linus Torvalds, 2005
  */
-#include "cache.h"
 #include "builtin.h"
 #include "parse-options.h"
 #include "userdiff.h"
-- 
2.2.1.532.g168b885.dirty

← back to recent threads