{"thread":{"id":"38334","subject":"[PATCH] cat-file: remove unnecessary #include","startedAt":"2015-01-10T18:29:18Z","lastAt":"2015-01-10T18:29:18Z","messageCount":1,"participants":["Alexander Kuleshov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254536","messageId":"1420914558-5324-1-git-send-email-kuleshovmail@gmail.com","threadId":"38334","inReplyTo":null,"subject":"[PATCH] cat-file: remove unnecessary #include","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-10T18:29:18Z","receivedAt":"2015-01-10T18:29:18Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"\"cache.h\" is already included in \"builtin.h\"\n\nIt appeared at e83c51 (Initial revision of \"git\", the information manager\nfrom hell., 8 Apr 2005) and used cache.c API (get_sha1_hex and read_sha1_file).\nAfter this in the commit f81dae (Builtin git-cat-file., ) was included\n\"builtin.h\", which already includes \"cache.h\", so we no need to include it in\nthe cat-file.c\n\nSigned-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>\n---\n builtin/cat-file.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/cat-file.c b/builtin/cat-file.c\nindex 750b5a2..2e6aaa1 100644\n--- a/builtin/cat-file.c\n+++ b/builtin/cat-file.c\n@@ -3,7 +3,6 @@\n  *\n  * Copyright (C) Linus Torvalds, 2005\n  */\n-#include \"cache.h\"\n #include \"builtin.h\"\n #include \"parse-options.h\"\n #include \"userdiff.h\"\n-- \n2.2.1.532.g168b885.dirty\n"}]}