threads / patch / 37971

patchRe: [PATCH] difftool: honor --trust-exit-code for builtin tools

Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools

## tl;dr

2 messages between Nov 15, 2014 and Nov 15, 2014. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

David Aguilar· Nov 15, 2014, 00:27 UTC · lore
Adri sent me this directly but I think it should have gone to the list.
Adri, if you don't mind, Junio can add:
Tested-by: Adri Farr <14farresa@gmail.com>
...to the commit message trailer since it looks like it's happy.
Thanks for testing!

cheers, David

----- Forwarded message from Adri Farr <14farresa@gmail.com> -----
Date: Sat, 15 Nov 2014 00:10:12 +0100
From: Adri Farr <14farresa@gmail.com>
To: David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools

I have tested this patch both in vim and meld and it works wonderfully. Thank you for the time put into this. I should have provided feedback back when the patch was proposed. I guess it's never too late :).

2014-11-14 22:57 GMT+01:00 David Aguilar <davvid@gmail.com>:
> [snip]
----- End forwarded message -----
Adri Farr· Nov 15, 2014, 14:22 UTC · re: David Aguilar · lore

Oh, sorry about that. I didn't realize I was directly responding to you. Apologizes. Hopefully I'm doing it right this time. I don't have much experience with mailing lists, and Gmail doesn't seem to help. You don't need to add the 'Tested-by' line. Testing is the least I can do. If you still want to add that line, my full name is 'Adria Farres'. Thank you!

2014-11-15 1:27 GMT+01:00 David Aguilar <davvid@gmail.com>:
Show 30 quoted lines
>
> Adri sent me this directly but I think it should have gone to the list.
>
> Adri, if you don't mind, Junio can add:
>
> Tested-by: Adri Farr <14farresa@gmail.com>
>
> ...to the commit message trailer since it looks like it's happy.
>
> Thanks for testing!
>
> cheers,
> David
>
> ----- Forwarded message from Adri Farr <14farresa@gmail.com> -----
>
> Date: Sat, 15 Nov 2014 00:10:12 +0100
> From: Adri Farr <14farresa@gmail.com>
> To: David Aguilar <davvid@gmail.com>
> Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools
>
> I have tested this patch both in vim and meld and it works
> wonderfully. Thank you for the time put into this. I should have
> provided feedback back when the patch was proposed. I guess it's never
> too late :).
>
> 2014-11-14 22:57 GMT+01:00 David Aguilar <davvid@gmail.com>:
>> [snip]
>
> ----- End forwarded message -----

← back to recent threads