# Re: [PATCH] difftool: honor --trust-exit-code for builtin tools 2 messages from 2014-11-15 to 2014-11-15. Participants: David Aguilar, Adri Farr. Thread: https://gitlist.dev/t/37971 ## David Aguilar, 2014-11-15 00:27 Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools Message-ID: <20141115002710.GA72216@gmail.com> URL: https://gitlist.dev/e/20141115002710.GA72216%40gmail.com ``` Adri sent me this directly but I think it should have gone to the list. Adri, if you don't mind, Junio can add: Tested-by: Adri Farr <14farresa@gmail.com> ...to the commit message trailer since it looks like it's happy. Thanks for testing! cheers, David ----- Forwarded message from Adri Farr <14farresa@gmail.com> ----- Date: Sat, 15 Nov 2014 00:10:12 +0100 From: Adri Farr <14farresa@gmail.com> To: David Aguilar Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools I have tested this patch both in vim and meld and it works wonderfully. Thank you for the time put into this. I should have provided feedback back when the patch was proposed. I guess it's never too late :). 2014-11-14 22:57 GMT+01:00 David Aguilar : > [snip] ----- End forwarded message ----- ``` ## Adri Farr, 2014-11-15 14:22 Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools Message-ID: URL: https://gitlist.dev/e/CAPfWmhiPgka9ok30eXswcy1jb%2Bg4pcNV80QM-YVvn5r-KebAUQ%40mail.gmail.com In-Reply-To: <20141115002710.GA72216@gmail.com> ``` Oh, sorry about that. I didn't realize I was directly responding to you. Apologizes. Hopefully I'm doing it right this time. I don't have much experience with mailing lists, and Gmail doesn't seem to help. You don't need to add the 'Tested-by' line. Testing is the least I can do. If you still want to add that line, my full name is 'Adria Farres'. Thank you! 2014-11-15 1:27 GMT+01:00 David Aguilar : > > Adri sent me this directly but I think it should have gone to the list. > > Adri, if you don't mind, Junio can add: > > Tested-by: Adri Farr <14farresa@gmail.com> > > ...to the commit message trailer since it looks like it's happy. > > Thanks for testing! > > cheers, > David > > ----- Forwarded message from Adri Farr <14farresa@gmail.com> ----- > > Date: Sat, 15 Nov 2014 00:10:12 +0100 > From: Adri Farr <14farresa@gmail.com> > To: David Aguilar > Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools > > I have tested this patch both in vim and meld and it works > wonderfully. Thank you for the time put into this. I should have > provided feedback back when the patch was proposed. I guess it's never > too late :). > > 2014-11-14 22:57 GMT+01:00 David Aguilar : >> [snip] > > ----- End forwarded message ----- ```