threads / patch / 3786

patch, 4 partscontrib/git-svn: ensure repo-config returns a value before using it

Subject: [PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it

## tl;dr

3 messages between Apr 3, 2006 and Apr 3, 2006. Diffs are folded; open one to read it.

replies: 2people: 1as markdown or json

Eric Wong· Apr 3, 2006, 22:18 UTC · lore

fetching from repos without an authors-file defined was broken.

Signed-off-by: Eric Wong <normalperson@yhbt.net>

---

 contrib/git-svn/git-svn.perl |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

029626bf987cff7ba42d8158c687cf4902765968

Show changes to contrib/git-svn/git-svn.perl +6 −3

diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl
index edfb19c..e7fff46 100755
--- a/contrib/git-svn/git-svn.perl
+++ b/contrib/git-svn/git-svn.perl
@@ -77,10 +77,13 @@ foreach my $o (keys %opts) {
 	$arg .= ' --bool' if ($o !~ /=[sfi]$/);
 	$arg .= " svn.$key"; # $key only matches [a-z\-], always shell-safe
 	if (ref $v eq 'ARRAY') {
-		chomp(@$v = `$arg`);
+		chomp(my @tmp = `$arg`);
+		@$v = @tmp if @tmp;
 	} else {
-		chomp($$v = `$arg`);
-		$$v = 0 if $$v eq 'false';
+		chomp(my $tmp = `$arg`);
+		if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {
+			$$v = $tmp;
+		}
 	}
 }

-- 
1.3.0.rc1.g595e

Eric Wong· Apr 3, 2006, 22:18 UTC · re: Eric Wong · lore

[PATCH 4/4] contrib/git-svn: make sure our git-svn is up-to-date for test

Bugs like the last one could've been avoided if it weren't for this...

Signed-off-by: Eric Wong <normalperson@yhbt.net>

---

 contrib/git-svn/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

d3ce1325c4933cd0e5f8f9810b2ffc33ddf45aac

Show changes to contrib/git-svn/Makefile +1 −1

diff --git a/contrib/git-svn/Makefile b/contrib/git-svn/Makefile
index d7f1643..acedf73 100644
--- a/contrib/git-svn/Makefile
+++ b/contrib/git-svn/Makefile
@@ -28,7 +28,7 @@ git-svn.xml : git-svn.txt
 git-svn.html : git-svn.txt
 	asciidoc -b xhtml11 -d manpage \
 		-f ../../Documentation/asciidoc.conf $<
-test:
+test: git-svn
 	cd t && $(SHELL) ./t0000-contrib-git-svn.sh
 
 clean:

-- 
1.3.0.rc1.g595e

Eric Wong· Apr 3, 2006, 22:21 UTC · re: Eric Wong · lore

Re: [PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it

Subject: Re: [PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it
                    ^ oops, disregard that, these should've been 1/2 and 2/2

-- 
Eric Wong