{"thread":{"id":"3786","subject":"[PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it","startedAt":"2006-04-03T22:18:48Z","lastAt":"2006-04-03T22:21:33Z","messageCount":3,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"18306","messageId":"11441027292908-git-send-email-normalperson@yhbt.net","threadId":"3786","inReplyTo":null,"subject":"[PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-04-03T22:18:48Z","receivedAt":"2006-04-03T22:18:48Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"fetching from repos without an authors-file defined was broken.\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n\n---\n\n contrib/git-svn/git-svn.perl |    9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\n029626bf987cff7ba42d8158c687cf4902765968\ndiff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl\nindex edfb19c..e7fff46 100755\n--- a/contrib/git-svn/git-svn.perl\n+++ b/contrib/git-svn/git-svn.perl\n@@ -77,10 +77,13 @@ foreach my $o (keys %opts) {\n \t$arg .= ' --bool' if ($o !~ /=[sfi]$/);\n \t$arg .= \" svn.$key\"; # $key only matches [a-z\\-], always shell-safe\n \tif (ref $v eq 'ARRAY') {\n-\t\tchomp(@$v = `$arg`);\n+\t\tchomp(my @tmp = `$arg`);\n+\t\t@$v = @tmp if @tmp;\n \t} else {\n-\t\tchomp($$v = `$arg`);\n-\t\t$$v = 0 if $$v eq 'false';\n+\t\tchomp(my $tmp = `$arg`);\n+\t\tif ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {\n+\t\t\t$$v = $tmp;\n+\t\t}\n \t}\n }\n \n-- \n1.3.0.rc1.g595e\n"},{"id":"18307","messageId":"11441027293976-git-send-email-normalperson@yhbt.net","threadId":"3786","inReplyTo":"11441027292908-git-send-email-normalperson@yhbt.net","subject":"[PATCH 4/4] contrib/git-svn: make sure our git-svn is up-to-date for test","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-04-03T22:18:49Z","receivedAt":"2006-04-03T22:18:49Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Bugs like the last one could've been avoided if it weren't for\nthis...\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n\n---\n\n contrib/git-svn/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\nd3ce1325c4933cd0e5f8f9810b2ffc33ddf45aac\ndiff --git a/contrib/git-svn/Makefile b/contrib/git-svn/Makefile\nindex d7f1643..acedf73 100644\n--- a/contrib/git-svn/Makefile\n+++ b/contrib/git-svn/Makefile\n@@ -28,7 +28,7 @@ git-svn.xml : git-svn.txt\n git-svn.html : git-svn.txt\n \tasciidoc -b xhtml11 -d manpage \\\n \t\t-f ../../Documentation/asciidoc.conf $<\n-test:\n+test: git-svn\n \tcd t && $(SHELL) ./t0000-contrib-git-svn.sh\n \n clean:\n-- \n1.3.0.rc1.g595e\n"},{"id":"18308","messageId":"20060403222133.GA16726@hand.yhbt.net","threadId":"3786","inReplyTo":"11441027292908-git-send-email-normalperson@yhbt.net","subject":"Re: [PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-04-03T22:21:33Z","receivedAt":"2006-04-03T22:21:33Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Subject: Re: [PATCH 3/4] contrib/git-svn: ensure repo-config returns a value before using it\n                    ^ oops, disregard that, these should've been 1/2 and 2/2\n\n-- \nEric Wong\n"}]}