threads / patch / 3727

patchDo not print header in diff-tree --root unless asked to

Subject: [PATCH] Do not print header in diff-tree --root unless asked to

## tl;dr

3 messages between Mar 25, 2006 and Mar 26, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Petr Baudis· Mar 25, 2006, 23:28 UTC · lore

Currently cg-log -f is broken (shows sha1 in files list for the initial commit) since git-diff-tree would always return the sha1 of the commit when --root was passed. I assume it should do this only when -v was also passed; I'm certain that I don't want it when processing the output.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 diff-tree.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Show changes to diff-tree.c +2 −1

diff --git a/diff-tree.c b/diff-tree.c
index f55a35a..8d82b5b 100644
--- a/diff-tree.c
+++ b/diff-tree.c
@@ -107,7 +107,8 @@ static int diff_tree_commit(struct commi
 
 	/* Root commit? */
 	if (show_root_diff && !commit->parents) {
-		header = generate_header(sha1, NULL, commit);
+		if (verbose_header)
+			header = generate_header(sha1, NULL, commit);
 		diff_root_tree(sha1, "");
 	}

Junio C Hamano· Mar 26, 2006, 00:48 UTC · re: Petr Baudis · lore

Re: [PATCH] Do not print header in diff-tree --root unless asked to

Petr Baudis <pasky@suse.cz> writes:

> ... git-diff-tree would always return the sha1 of the commit
> when --root was passed.

I am not sure why this change is needed.

The output from "git-diff-tree --root e83c51" (the very initial "git") and "git-diff-tree 8bc9a0" (the second commit) without any other parameters (specifically, there is no '-v') look comparable right now, but I suspect this change would break it.

Petr Baudis· Mar 26, 2006, 01:50 UTC · re: Junio C Hamano · lore

Re: [PATCH] Do not print header in diff-tree --root unless asked to

Dear diary, on Sun, Mar 26, 2006 at 01:48:36AM CET, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 11 quoted lines

> Petr Baudis <pasky@suse.cz> writes:
> 
> > ... git-diff-tree would always return the sha1 of the commit
> > when --root was passed.
> 
> I am not sure why this change is needed.
> 
> The output from "git-diff-tree --root e83c51" (the very initial
> "git") and "git-diff-tree 8bc9a0" (the second commit) without
> any other parameters (specifically, there is no '-v') look
> comparable right now, but I suspect this change would break it.

I was confused by the fact that

	git-diff-tree --root rev1

gives a different output than

	git-diff-tree --root rev1 rev2

Sorry for the noise,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.