# [PATCH] Do not print header in diff-tree --root unless asked to 3 messages from 2006-03-25 to 2006-03-26. Participants: Petr Baudis, Junio C Hamano. Thread: https://gitlist.dev/t/3727 ## Petr Baudis, 2006-03-25 23:28 Subject: [PATCH] Do not print header in diff-tree --root unless asked to Message-ID: <20060325232807.9146.12846.stgit@machine.or.cz> URL: https://gitlist.dev/e/20060325232807.9146.12846.stgit%40machine.or.cz ``` Currently cg-log -f is broken (shows sha1 in files list for the initial commit) since git-diff-tree would always return the sha1 of the commit when --root was passed. I assume it should do this only when -v was also passed; I'm certain that I don't want it when processing the output. Signed-off-by: Petr Baudis --- diff-tree.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/diff-tree.c b/diff-tree.c index f55a35a..8d82b5b 100644 --- a/diff-tree.c +++ b/diff-tree.c @@ -107,7 +107,8 @@ static int diff_tree_commit(struct commi /* Root commit? */ if (show_root_diff && !commit->parents) { - header = generate_header(sha1, NULL, commit); + if (verbose_header) + header = generate_header(sha1, NULL, commit); diff_root_tree(sha1, ""); } ``` ## Junio C Hamano, 2006-03-26 00:48 Subject: Re: [PATCH] Do not print header in diff-tree --root unless asked to Message-ID: <7vu09mt4ij.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vu09mt4ij.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20060325232807.9146.12846.stgit@machine.or.cz> ``` Petr Baudis writes: > ... git-diff-tree would always return the sha1 of the commit > when --root was passed. I am not sure why this change is needed. The output from "git-diff-tree --root e83c51" (the very initial "git") and "git-diff-tree 8bc9a0" (the second commit) without any other parameters (specifically, there is no '-v') look comparable right now, but I suspect this change would break it. ``` ## Petr Baudis, 2006-03-26 01:50 Subject: Re: [PATCH] Do not print header in diff-tree --root unless asked to Message-ID: <20060326015024.GC18185@pasky.or.cz> URL: https://gitlist.dev/e/20060326015024.GC18185%40pasky.or.cz In-Reply-To: <7vu09mt4ij.fsf@assigned-by-dhcp.cox.net> ``` Dear diary, on Sun, Mar 26, 2006 at 01:48:36AM CET, I got a letter where Junio C Hamano said that... > Petr Baudis writes: > > > ... git-diff-tree would always return the sha1 of the commit > > when --root was passed. > > I am not sure why this change is needed. > > The output from "git-diff-tree --root e83c51" (the very initial > "git") and "git-diff-tree 8bc9a0" (the second commit) without > any other parameters (specifically, there is no '-v') look > comparable right now, but I suspect this change would break it. I was confused by the fact that git-diff-tree --root rev1 gives a different output than git-diff-tree --root rev1 rev2 Sorry for the noise, -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Right now I am having amnesia and deja-vu at the same time. I think I have forgotten this before. ```