threads / patch / 36346

patchgitweb.conf.txt: fix typo

Subject: [PATCH] gitweb.conf.txt: fix typo

## tl;dr

3 messages between Apr 3, 2014 and Mar 31, 2015. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

git-patch@agt-the-walker.net· Apr 3, 2014, 20:49 UTC · lore
From: Jérôme Zago <git-patch@agt-the-walker.net>
"build-time" is used everywhere else.
Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
---
 Documentation/gitweb.conf.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/gitweb.conf.txt +1 −1
diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
index 952f503..8b25a2f 100644
--- a/Documentation/gitweb.conf.txt
+++ b/Documentation/gitweb.conf.txt
@@ -482,7 +482,7 @@ project config.  Per-repository configuration takes precedence over value
 composed from `@git_base_url_list` elements and project name.
 +
 You can setup one single value (single entry/item in this list) at build
-time by setting the `GITWEB_BASE_URL` built-time configuration variable.
+time by setting the `GITWEB_BASE_URL` build-time configuration variable.
 By default it is set to (), i.e. an empty list.  This means that gitweb
 would not try to create project URL (to fetch) from project name.
 
-- 
1.9.1
Jakub Narębski· Mar 31, 2015, 13:06 UTC · re: git-patch@agt-the-walker.net · lore

Re: [PATCH] gitweb.conf.txt: fix typo

On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
Show 5 quoted lines
> From: Jérôme Zago <git-patch@agt-the-walker.net>
>
> "build-time" is used everywhere else.
>
> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>

You are right, it is variable set during build process, not after project is built.

ACK (for what it is worth).
Acked-by: Jakub Narebski <jnareb@gmail.com>
Show 18 quoted lines
> ---
>   Documentation/gitweb.conf.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
> index 952f503..8b25a2f 100644
> --- a/Documentation/gitweb.conf.txt
> +++ b/Documentation/gitweb.conf.txt
> @@ -482,7 +482,7 @@ project config.  Per-repository configuration takes precedence over value
>   composed from `@git_base_url_list` elements and project name.
>   +
>   You can setup one single value (single entry/item in this list) at build
> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
>   By default it is set to (), i.e. an empty list.  This means that gitweb
>   would not try to create project URL (to fetch) from project name.
>
>
Junio C Hamano· Mar 31, 2015, 20:28 UTC · re: Jakub Narębski · lore

Re: [PATCH] gitweb.conf.txt: fix typo

Jakub Narębski <jnareb@gmail.com> writes:
Show 13 quoted lines
> On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
>> From: Jérôme Zago <git-patch@agt-the-walker.net>
>>
>> "build-time" is used everywhere else.
>>
>> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
>
> You are right, it is variable set during build process,
> not after project is built.
>
> ACK (for what it is worth).
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
Thanks; the patch is linewrapped but I can fix it up.

It is funny to see an ack to a patch that is almost a year old, though ;-)

Show 20 quoted lines
>
>> ---
>>   Documentation/gitweb.conf.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
>> index 952f503..8b25a2f 100644
>> --- a/Documentation/gitweb.conf.txt
>> +++ b/Documentation/gitweb.conf.txt
>> @@ -482,7 +482,7 @@ project config.  Per-repository configuration
>> takes precedence over value
>>   composed from `@git_base_url_list` elements and project name.
>>   +
>>   You can setup one single value (single entry/item in this list) at build
>> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
>> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
>>   By default it is set to (), i.e. an empty list.  This means that gitweb
>>   would not try to create project URL (to fetch) from project name.
>>
>>

← back to recent threads