# [PATCH] gitweb.conf.txt: fix typo 3 messages from 2014-04-03 to 2015-03-31. Participants: git-patch@agt-the-walker.net, Jakub Narębski, Junio C Hamano. Thread: https://gitlist.dev/t/36346 ## git-patch@agt-the-walker.net, 2014-04-03 20:49 Subject: [PATCH] gitweb.conf.txt: fix typo Message-ID: <1396558187-5674-1-git-send-email-git-patch@agt-the-walker.net> URL: https://gitlist.dev/e/1396558187-5674-1-git-send-email-git-patch%40agt-the-walker.net ``` From: Jérôme Zago "build-time" is used everywhere else. Signed-off-by: Jérôme Zago --- Documentation/gitweb.conf.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt index 952f503..8b25a2f 100644 --- a/Documentation/gitweb.conf.txt +++ b/Documentation/gitweb.conf.txt @@ -482,7 +482,7 @@ project config. Per-repository configuration takes precedence over value composed from `@git_base_url_list` elements and project name. + You can setup one single value (single entry/item in this list) at build -time by setting the `GITWEB_BASE_URL` built-time configuration variable. +time by setting the `GITWEB_BASE_URL` build-time configuration variable. By default it is set to (), i.e. an empty list. This means that gitweb would not try to create project URL (to fetch) from project name. -- 1.9.1 ``` ## Jakub Narębski, 2015-03-31 13:06 Subject: Re: [PATCH] gitweb.conf.txt: fix typo Message-ID: <551A9BE9.3070907@gmail.com> URL: https://gitlist.dev/e/551A9BE9.3070907%40gmail.com In-Reply-To: <1396558187-5674-1-git-send-email-git-patch@agt-the-walker.net> ``` On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote: > From: Jérôme Zago > > "build-time" is used everywhere else. > > Signed-off-by: Jérôme Zago You are right, it is variable set during build process, not after project is built. ACK (for what it is worth). Acked-by: Jakub Narebski > --- > Documentation/gitweb.conf.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt > index 952f503..8b25a2f 100644 > --- a/Documentation/gitweb.conf.txt > +++ b/Documentation/gitweb.conf.txt > @@ -482,7 +482,7 @@ project config. Per-repository configuration takes precedence over value > composed from `@git_base_url_list` elements and project name. > + > You can setup one single value (single entry/item in this list) at build > -time by setting the `GITWEB_BASE_URL` built-time configuration variable. > +time by setting the `GITWEB_BASE_URL` build-time configuration variable. > By default it is set to (), i.e. an empty list. This means that gitweb > would not try to create project URL (to fetch) from project name. > > ``` ## Junio C Hamano, 2015-03-31 20:28 Subject: Re: [PATCH] gitweb.conf.txt: fix typo Message-ID: URL: https://gitlist.dev/e/xmqq4mp0rjwv.fsf%40gitster.dls.corp.google.com In-Reply-To: <551A9BE9.3070907@gmail.com> ``` Jakub Narębski writes: > On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote: >> From: Jérôme Zago >> >> "build-time" is used everywhere else. >> >> Signed-off-by: Jérôme Zago > > You are right, it is variable set during build process, > not after project is built. > > ACK (for what it is worth). > > Acked-by: Jakub Narebski Thanks; the patch is linewrapped but I can fix it up. It is funny to see an ack to a patch that is almost a year old, though ;-) > >> --- >> Documentation/gitweb.conf.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt >> index 952f503..8b25a2f 100644 >> --- a/Documentation/gitweb.conf.txt >> +++ b/Documentation/gitweb.conf.txt >> @@ -482,7 +482,7 @@ project config. Per-repository configuration >> takes precedence over value >> composed from `@git_base_url_list` elements and project name. >> + >> You can setup one single value (single entry/item in this list) at build >> -time by setting the `GITWEB_BASE_URL` built-time configuration variable. >> +time by setting the `GITWEB_BASE_URL` build-time configuration variable. >> By default it is set to (), i.e. an empty list. This means that gitweb >> would not try to create project URL (to fetch) from project name. >> >> ```