threads / patch / 36019

v3Place cache.h at the first place to match general rule

Subject: [PATCH v3] Place cache.h at the first place to match general rule

## tl;dr

2 messages between Mar 2, 2014 and Mar 3, 2014. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Sun He· Mar 2, 2014, 08:31 UTC · lore

 The general rule is if cache.h or git-compat-util.h is included,
 it is the first #include.
 As builtin.h starts with git-compat-util.h, files that start with builtin.h
 are not changed.

Helped-by: Duy Nguyen <pclouds@gmail.com>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Sun He <sunheehnus@gmail.com>
---

 "PATCH v3" fix the position of information I want to convey to readers,
 with the directions of Eric Sunshine.

 sigchain.c and test-sigchain.c are started with "sigchain.h"
 I checked sigchain.h, and it didn't import any bug.
 But to keep consistant with general rule, we should take this patch.

 sigchain.c      | 2 +-
 test-sigchain.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Show changes to 2 files +2 −2

sigchain.c, test-sigchain.c

diff --git a/sigchain.c b/sigchain.c
index 1118b99..faa375d 100644
--- a/sigchain.c
+++ b/sigchain.c
@@ -1,5 +1,5 @@
-#include "sigchain.h"
 #include "cache.h"
+#include "sigchain.h"
 
 #define SIGCHAIN_MAX_SIGNALS 32
 
diff --git a/test-sigchain.c b/test-sigchain.c
index 42db234..e499fce 100644
--- a/test-sigchain.c
+++ b/test-sigchain.c
@@ -1,5 +1,5 @@
-#include "sigchain.h"
 #include "cache.h"
+#include "sigchain.h"
 
 #define X(f) \
 static void f(int sig) { \

-- 
1.9.0.138.g2de3478.dirty

Eric Sunshine· Mar 3, 2014, 07:44 UTC · re: Sun He · lore

Re: [PATCH v3] Place cache.h at the first place to match general rule

On Sun, Mar 2, 2014 at 3:31 AM, Sun He <sunheehnus@gmail.com> wrote:

>  The general rule is if cache.h or git-compat-util.h is included,
>  it is the first #include.
>  As builtin.h starts with git-compat-util.h, files that start with builtin.h
>  are not changed.

Minor: Odd one-space indentation on each line of commit message.

Show 41 quoted lines

> Helped-by: Duy Nguyen <pclouds@gmail.com>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  "PATCH v3" fix the position of information I want to convey to readers,
>  with the directions of Eric Sunshine.
>
>  sigchain.c and test-sigchain.c are started with "sigchain.h"
>  I checked sigchain.h, and it didn't import any bug.
>  But to keep consistant with general rule, we should take this patch.
>
>  sigchain.c      | 2 +-
>  test-sigchain.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sigchain.c b/sigchain.c
> index 1118b99..faa375d 100644
> --- a/sigchain.c
> +++ b/sigchain.c
> @@ -1,5 +1,5 @@
> -#include "sigchain.h"
>  #include "cache.h"
> +#include "sigchain.h"
>
>  #define SIGCHAIN_MAX_SIGNALS 32
>
> diff --git a/test-sigchain.c b/test-sigchain.c
> index 42db234..e499fce 100644
> --- a/test-sigchain.c
> +++ b/test-sigchain.c
> @@ -1,5 +1,5 @@
> -#include "sigchain.h"
>  #include "cache.h"
> +#include "sigchain.h"
>
>  #define X(f) \
>  static void f(int sig) { \
> --
> 1.9.0.138.g2de3478.dirty
>