{"thread":{"id":"36019","subject":"[PATCH v3] Place cache.h at the first place to match general rule","startedAt":"2014-03-02T08:31:41Z","lastAt":"2014-03-03T07:44:09Z","messageCount":2,"participants":["Sun He","Eric Sunshine"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"235789","messageId":"1393749101-14985-1-git-send-email-sunheehnus@gmail.com","threadId":"36019","inReplyTo":null,"subject":"[PATCH v3] Place cache.h at the first place to match general rule","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-02T08:31:41Z","receivedAt":"2014-03-02T08:31:41Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":" The general rule is if cache.h or git-compat-util.h is included,\n it is the first #include.\n As builtin.h starts with git-compat-util.h, files that start with builtin.h\n are not changed.\n\nHelped-by: Duy Nguyen <pclouds@gmail.com>\nHelped-by: Eric Sunshine <sunshine@sunshineco.com>\nSigned-off-by: Sun He <sunheehnus@gmail.com>\n---\n\n \"PATCH v3\" fix the position of information I want to convey to readers,\n with the directions of Eric Sunshine.\n\n sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n I checked sigchain.h, and it didn't import any bug.\n But to keep consistant with general rule, we should take this patch.\n\n sigchain.c      | 2 +-\n test-sigchain.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/sigchain.c b/sigchain.c\nindex 1118b99..faa375d 100644\n--- a/sigchain.c\n+++ b/sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define SIGCHAIN_MAX_SIGNALS 32\n \ndiff --git a/test-sigchain.c b/test-sigchain.c\nindex 42db234..e499fce 100644\n--- a/test-sigchain.c\n+++ b/test-sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define X(f) \\\n static void f(int sig) { \\\n-- \n1.9.0.138.g2de3478.dirty\n"},{"id":"235843","messageId":"CAPig+cRPjf4vCsPzOSoe+exw4o5rN_W=N7N0k5=rj=J9xsYSeQ@mail.gmail.com","threadId":"36019","inReplyTo":"1393749101-14985-1-git-send-email-sunheehnus@gmail.com","subject":"Re: [PATCH v3] Place cache.h at the first place to match general rule","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-03T07:44:09Z","receivedAt":"2014-03-03T07:44:09Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Mar 2, 2014 at 3:31 AM, Sun He <sunheehnus@gmail.com> wrote:\n>  The general rule is if cache.h or git-compat-util.h is included,\n>  it is the first #include.\n>  As builtin.h starts with git-compat-util.h, files that start with builtin.h\n>  are not changed.\n\nMinor: Odd one-space indentation on each line of commit message.\n\n> Helped-by: Duy Nguyen <pclouds@gmail.com>\n> Helped-by: Eric Sunshine <sunshine@sunshineco.com>\n> Signed-off-by: Sun He <sunheehnus@gmail.com>\n> ---\n>\n>  \"PATCH v3\" fix the position of information I want to convey to readers,\n>  with the directions of Eric Sunshine.\n>\n>  sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n>  I checked sigchain.h, and it didn't import any bug.\n>  But to keep consistant with general rule, we should take this patch.\n>\n>  sigchain.c      | 2 +-\n>  test-sigchain.c | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/sigchain.c b/sigchain.c\n> index 1118b99..faa375d 100644\n> --- a/sigchain.c\n> +++ b/sigchain.c\n> @@ -1,5 +1,5 @@\n> -#include \"sigchain.h\"\n>  #include \"cache.h\"\n> +#include \"sigchain.h\"\n>\n>  #define SIGCHAIN_MAX_SIGNALS 32\n>\n> diff --git a/test-sigchain.c b/test-sigchain.c\n> index 42db234..e499fce 100644\n> --- a/test-sigchain.c\n> +++ b/test-sigchain.c\n> @@ -1,5 +1,5 @@\n> -#include \"sigchain.h\"\n>  #include \"cache.h\"\n> +#include \"sigchain.h\"\n>\n>  #define X(f) \\\n>  static void f(int sig) { \\\n> --\n> 1.9.0.138.g2de3478.dirty\n>\n"}]}