threads / patch / 35996

patchbuiltin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning

Subject: [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning

## tl;dr

One message between Feb 28, 2014 and Feb 28, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Sun He· Feb 28, 2014, 15:37 UTC · lore
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
 builtin/pack-objects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/pack-objects.c +1 −1
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
 				utb.modtime = --last_mtime;
 				if (utime(pack_tmp_name, &utb) < 0)
 					warning("failed utime() on %s: %s",
-						tmpname, strerror(errno));
+						pack_tmp_name, strerror(errno));
 			}
 
 			/* Enough space for "-<sha-1>.pack"? */
-- 
1.9.0.138.g2de3478.dirty
---
The tmpname is uninitialized and it should a bug

← back to recent threads