{"thread":{"id":"35996","subject":"[PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning","startedAt":"2014-02-28T15:37:11Z","lastAt":"2014-02-28T15:37:11Z","messageCount":1,"participants":["Sun He"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"235627","messageId":"1393601831-17119-1-git-send-email-sunheehnus@gmail.com","threadId":"35996","inReplyTo":null,"subject":"[PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-02-28T15:37:11Z","receivedAt":"2014-02-28T15:37:11Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"Signed-off-by: Sun He <sunheehnus@gmail.com>\n---\n builtin/pack-objects.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\nindex c733379..4922ce5 100644\n--- a/builtin/pack-objects.c\n+++ b/builtin/pack-objects.c\n@@ -823,7 +823,7 @@ static void write_pack_file(void)\n \t\t\t\tutb.modtime = --last_mtime;\n \t\t\t\tif (utime(pack_tmp_name, &utb) < 0)\n \t\t\t\t\twarning(\"failed utime() on %s: %s\",\n-\t\t\t\t\t\ttmpname, strerror(errno));\n+\t\t\t\t\t\tpack_tmp_name, strerror(errno));\n \t\t\t}\n \n \t\t\t/* Enough space for \"-<sha-1>.pack\"? */\n-- \n1.9.0.138.g2de3478.dirty\n---\nThe tmpname is uninitialized and it should a bug\n"}]}