threads / patch / 35995

patchOPTION_NUMBER should be replaced by OPTION_CMDMODE

Subject: [PATCH] OPTION_NUMBER should be replaced by OPTION_CMDMODE

## tl;dr

One message between Feb 28, 2014 and Feb 28, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Sun He· Feb 28, 2014, 15:24 UTC · lore
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
 parse-options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to parse-options.c +1 −1
diff --git a/parse-options.c b/parse-options.c
index 7b8d3fa..59a52b0 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -371,7 +371,7 @@ static void parse_options_check(const struct option *opts)
 		case OPTION_NEGBIT:
 		case OPTION_SET_INT:
 		case OPTION_SET_PTR:
-		case OPTION_NUMBER:
+		case OPTION_CMDMODE:
 			if ((opts->flags & PARSE_OPT_OPTARG) ||
 			    !(opts->flags & PARSE_OPT_NOARG))
 				err |= optbug(opts, "should not accept an argument");
-- 
1.9.0.138.g2de3478.dirty
---
I came I came across this protential bug.
According to parse-options.h OPTION_CMDMODE is an option with noarguments and OPTION_NUMBER is special type option

Thanks,
He Sun

← back to recent threads