{"thread":{"id":"35995","subject":"[PATCH] OPTION_NUMBER should be replaced by OPTION_CMDMODE","startedAt":"2014-02-28T15:24:08Z","lastAt":"2014-02-28T15:24:08Z","messageCount":1,"participants":["Sun He"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"235626","messageId":"1393601048-16500-1-git-send-email-sunheehnus@gmail.com","threadId":"35995","inReplyTo":null,"subject":"[PATCH] OPTION_NUMBER should be replaced by OPTION_CMDMODE","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-02-28T15:24:08Z","receivedAt":"2014-02-28T15:24:08Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"Signed-off-by: Sun He <sunheehnus@gmail.com>\n---\n parse-options.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/parse-options.c b/parse-options.c\nindex 7b8d3fa..59a52b0 100644\n--- a/parse-options.c\n+++ b/parse-options.c\n@@ -371,7 +371,7 @@ static void parse_options_check(const struct option *opts)\n \t\tcase OPTION_NEGBIT:\n \t\tcase OPTION_SET_INT:\n \t\tcase OPTION_SET_PTR:\n-\t\tcase OPTION_NUMBER:\n+\t\tcase OPTION_CMDMODE:\n \t\t\tif ((opts->flags & PARSE_OPT_OPTARG) ||\n \t\t\t    !(opts->flags & PARSE_OPT_NOARG))\n \t\t\t\terr |= optbug(opts, \"should not accept an argument\");\n-- \n1.9.0.138.g2de3478.dirty\n---\nI came I came across this protential bug.\nAccording to parse-options.h OPTION_CMDMODE is an option with noarguments and OPTION_NUMBER is special type option\n\nThanks,\nHe Sun\n"}]}