threads / discuss / 35804

bash completion patch

Subject: bash completion patch

## tl;dr

5 messages between Feb 5, 2014 and Feb 10, 2014.

replies: 4people: 4as markdown or json

乙酸鋰· Feb 5, 2014, 15:13 UTC · lore
add --recurse-submodules
From 0390a24e2653e0cdb6bfb9a569c28e4d58002038 Mon Sep 17 00:00:00 2001
From: Sup Yut Sum <ch3cooli@gmail.com>
Date: Wed, 5 Feb 2014 23:09:46 +0800
Subject: [PATCH 1/1] bash completion: Add --recurse-submodules
---
 contrib/completion/git-completion.bash | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 9525343..87de809 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1221,14 +1221,20 @@ _git_difftool ()
 	__git_complete_revlist_file
 }
 
+__git_fetch_recurse_submodules="yes on-demand no"
+
 __git_fetch_options="
 	--quiet --verbose --append --upload-pack --force --keep --depth=
-	--tags --no-tags --all --prune --dry-run
+	--tags --no-tags --all --prune --dry-run --recurse-submodules=
 "
 
 _git_fetch ()
 {
 	case "$cur" in
+	--recurse-submodules=*)
+		__gitcomp "$__git_fetch_recurse_submodules" "" "${cur##--recurse-submodules=}"
+		return
+		;;
 	--*)
 		__gitcomp "$__git_fetch_options"
 		return
@@ -1583,6 +1589,10 @@ _git_pull ()
 	__git_complete_strategy && return
 
 	case "$cur" in
+	--recurse-submodules=*)
+		__gitcomp "$__git_fetch_recurse_submodules" "" "${cur##--recurse-submodules=}"
+		return
+		;;
 	--*)
 		__gitcomp "
 			--rebase --no-rebase
@@ -1595,6 +1605,8 @@ _git_pull ()
 	__git_complete_remote_or_refspec
 }
 
+__git_push_recurse_submodules="check on-demand"
+
 _git_push ()
 {
 	case "$prev" in
@@ -1607,10 +1619,15 @@ _git_push ()
 		__gitcomp_nl "$(__git_remotes)" "" "${cur##--repo=}"
 		return
 		;;
+	--recurse-submodules=*)
+		__gitcomp "$__git_push_recurse_submodules" "" "${cur##--recurse-submodules=}"
+		return
+		;;
 	--*)
 		__gitcomp "
 			--all --mirror --tags --dry-run --force --verbose
 			--receive-pack= --repo= --set-upstream
+			--recurse-submodules=
 		"
 		return
 		;;

-- 
1.8.5.2
Matthieu Moy· Feb 5, 2014, 16:08 UTC · re: 乙酸鋰 · lore

Re: bash completion patch

乙酸鋰 <ch3cooli@gmail.com> writes:
> add --recurse-submodules
Thanks for the patch, but it cannot be included as-is.

Please, read Documentation/SubmittingPatches in Git's source tree. In particular, the signed-off-by part. Also, don't use attachments to send you patches (git send-email can help) and don't forget to Cc Junio if you think your patch is ready for inclusion.

Thanks,
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Junio C Hamano· Feb 5, 2014, 18:47 UTC · re: Matthieu Moy · lore

Re: bash completion patch

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 10 quoted lines
> 乙酸鋰 <ch3cooli@gmail.com> writes:
>
>> add --recurse-submodules
>
> Thanks for the patch, but it cannot be included as-is.
>
> Please, read Documentation/SubmittingPatches in Git's source tree. In
> particular, the signed-off-by part. Also, don't use attachments to send
> you patches (git send-email can help) and don't forget to Cc Junio if
> you think your patch is ready for inclusion.

Heh, thanks. Everybody seems to think anything they send out to the list is ready for inclusion, so the last part may not be a piece of advice that is practically very useful, though ;-)

Thomas Rast· Feb 9, 2014, 08:58 UTC · re: Junio C Hamano · lore

Re: bash completion patch

Junio C Hamano <gitster@pobox.com> writes:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
[...]
Show 6 quoted lines
>> don't forget to Cc Junio if
>> you think your patch is ready for inclusion.
>
> Heh, thanks.  Everybody seems to think anything they send out to the
> list is ready for inclusion, so the last part may not be a piece of
> advice that is practically very useful, though ;-)

That happens to me a lot, too. Perhaps it would be a clearer signal if you had an alias (or just something like gitster+patch) that we can send it to if we mean "please include" instead of "what do you think of this"?

-- 
Thomas Rast
tr@thomasrast.ch
Junio C Hamano· Feb 10, 2014, 18:38 UTC · re: Thomas Rast · lore

Re: bash completion patch

Thomas Rast <tr@thomasrast.ch> writes:
Show 15 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
> [...]
>>> don't forget to Cc Junio if
>>> you think your patch is ready for inclusion.
>>
>> Heh, thanks.  Everybody seems to think anything they send out to the
>> list is ready for inclusion, so the last part may not be a piece of
>> advice that is practically very useful, though ;-)
>
> That happens to me a lot, too.  Perhaps it would be a clearer signal if
> you had an alias (or just something like gitster+patch) that we can send
> it to if we mean "please include" instead of "what do you think of this"?

The intention from regulars like you I can read from the tone of the message (or if you want to you can mention it in the log message).

If a clearer signal is really needed, perhaps we should say something like:

    Send any patch that has not been reviewed on the list fist to
    the list and area experts (you can learn who they are by running
    "git blame" and "git shortlog" on the part of the system you are
    touching) for review.  Once the patch gains list consensus that
    it is a good change, and the maintainer hasn't picked it up
    (perhaps it fell through cracks), resend it to the maintainer
    with Cc: to the list.
We could phrase it more brutally:
    If it is the first time a particular patch is sent to the list, it
    almost always is not ready for inclusion.
but I do not think that is a good idea.

← back to recent threads