{"thread":{"id":"35804","subject":"bash completion patch","startedAt":"2014-02-05T15:13:33Z","lastAt":"2014-02-10T18:38:21Z","messageCount":5,"participants":["乙酸鋰","Matthieu Moy","Junio C Hamano","Thomas Rast"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"234278","messageId":"CAHtLG6Qgxq84Eo__vaXw5RAmyRuPnK-pt6n36+cjT8nVnRQN=w@mail.gmail.com","threadId":"35804","inReplyTo":null,"subject":"bash completion patch","fromName":"乙酸鋰","fromEmail":"ch3cooli@gmail.com","sentAt":"2014-02-05T15:13:33Z","receivedAt":"2014-02-05T15:13:33Z","isPatch":false,"sender":{"key":"ch3cooli@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2804967?v=4"},"body":"add --recurse-submodules\n\n\nFrom 0390a24e2653e0cdb6bfb9a569c28e4d58002038 Mon Sep 17 00:00:00 2001\nFrom: Sup Yut Sum <ch3cooli@gmail.com>\nDate: Wed, 5 Feb 2014 23:09:46 +0800\nSubject: [PATCH 1/1] bash completion: Add --recurse-submodules\n\n---\n contrib/completion/git-completion.bash | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 9525343..87de809 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1221,14 +1221,20 @@ _git_difftool ()\n \t__git_complete_revlist_file\n }\n \n+__git_fetch_recurse_submodules=\"yes on-demand no\"\n+\n __git_fetch_options=\"\n \t--quiet --verbose --append --upload-pack --force --keep --depth=\n-\t--tags --no-tags --all --prune --dry-run\n+\t--tags --no-tags --all --prune --dry-run --recurse-submodules=\n \"\n \n _git_fetch ()\n {\n \tcase \"$cur\" in\n+\t--recurse-submodules=*)\n+\t\t__gitcomp \"$__git_fetch_recurse_submodules\" \"\" \"${cur##--recurse-submodules=}\"\n+\t\treturn\n+\t\t;;\n \t--*)\n \t\t__gitcomp \"$__git_fetch_options\"\n \t\treturn\n@@ -1583,6 +1589,10 @@ _git_pull ()\n \t__git_complete_strategy && return\n \n \tcase \"$cur\" in\n+\t--recurse-submodules=*)\n+\t\t__gitcomp \"$__git_fetch_recurse_submodules\" \"\" \"${cur##--recurse-submodules=}\"\n+\t\treturn\n+\t\t;;\n \t--*)\n \t\t__gitcomp \"\n \t\t\t--rebase --no-rebase\n@@ -1595,6 +1605,8 @@ _git_pull ()\n \t__git_complete_remote_or_refspec\n }\n \n+__git_push_recurse_submodules=\"check on-demand\"\n+\n _git_push ()\n {\n \tcase \"$prev\" in\n@@ -1607,10 +1619,15 @@ _git_push ()\n \t\t__gitcomp_nl \"$(__git_remotes)\" \"\" \"${cur##--repo=}\"\n \t\treturn\n \t\t;;\n+\t--recurse-submodules=*)\n+\t\t__gitcomp \"$__git_push_recurse_submodules\" \"\" \"${cur##--recurse-submodules=}\"\n+\t\treturn\n+\t\t;;\n \t--*)\n \t\t__gitcomp \"\n \t\t\t--all --mirror --tags --dry-run --force --verbose\n \t\t\t--receive-pack= --repo= --set-upstream\n+\t\t\t--recurse-submodules=\n \t\t\"\n \t\treturn\n \t\t;;\n-- \n1.8.5.2\n\n"},{"id":"234279","messageId":"vpqk3d9o83t.fsf@anie.imag.fr","threadId":"35804","inReplyTo":"CAHtLG6Qgxq84Eo__vaXw5RAmyRuPnK-pt6n36+cjT8nVnRQN=w@mail.gmail.com","subject":"Re: bash completion patch","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-02-05T16:08:22Z","receivedAt":"2014-02-05T16:08:22Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"乙酸鋰 <ch3cooli@gmail.com> writes:\n\n> add --recurse-submodules\n\nThanks for the patch, but it cannot be included as-is.\n\nPlease, read Documentation/SubmittingPatches in Git's source tree. In\nparticular, the signed-off-by part. Also, don't use attachments to send\nyou patches (git send-email can help) and don't forget to Cc Junio if\nyou think your patch is ready for inclusion.\n\nThanks,\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"234309","messageId":"xmqq4n4d5rcn.fsf@gitster.dls.corp.google.com","threadId":"35804","inReplyTo":"vpqk3d9o83t.fsf@anie.imag.fr","subject":"Re: bash completion patch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-02-05T18:47:36Z","receivedAt":"2014-02-05T18:47:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:\n\n> 乙酸鋰 <ch3cooli@gmail.com> writes:\n>\n>> add --recurse-submodules\n>\n> Thanks for the patch, but it cannot be included as-is.\n>\n> Please, read Documentation/SubmittingPatches in Git's source tree. In\n> particular, the signed-off-by part. Also, don't use attachments to send\n> you patches (git send-email can help) and don't forget to Cc Junio if\n> you think your patch is ready for inclusion.\n\nHeh, thanks.  Everybody seems to think anything they send out to the\nlist is ready for inclusion, so the last part may not be a piece of\nadvice that is practically very useful, though ;-)\n"},{"id":"234540","messageId":"874n48ll1i.fsf@thomasrast.ch","threadId":"35804","inReplyTo":"xmqq4n4d5rcn.fsf@gitster.dls.corp.google.com","subject":"Re: bash completion patch","fromName":"Thomas Rast","fromEmail":"tr@thomasrast.ch","sentAt":"2014-02-09T08:58:33Z","receivedAt":"2014-02-09T08:58:33Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:\n>\n[...]\n>> don't forget to Cc Junio if\n>> you think your patch is ready for inclusion.\n>\n> Heh, thanks.  Everybody seems to think anything they send out to the\n> list is ready for inclusion, so the last part may not be a piece of\n> advice that is practically very useful, though ;-)\n\nThat happens to me a lot, too.  Perhaps it would be a clearer signal if\nyou had an alias (or just something like gitster+patch) that we can send\nit to if we mean \"please include\" instead of \"what do you think of this\"?\n\n-- \nThomas Rast\ntr@thomasrast.ch\n"},{"id":"234588","messageId":"xmqqsirqstia.fsf@gitster.dls.corp.google.com","threadId":"35804","inReplyTo":"874n48ll1i.fsf@thomasrast.ch","subject":"Re: bash completion patch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-02-10T18:38:21Z","receivedAt":"2014-02-10T18:38:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast <tr@thomasrast.ch> writes:\n\n> Junio C Hamano <gitster@pobox.com> writes:\n>\n>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:\n>>\n> [...]\n>>> don't forget to Cc Junio if\n>>> you think your patch is ready for inclusion.\n>>\n>> Heh, thanks.  Everybody seems to think anything they send out to the\n>> list is ready for inclusion, so the last part may not be a piece of\n>> advice that is practically very useful, though ;-)\n>\n> That happens to me a lot, too.  Perhaps it would be a clearer signal if\n> you had an alias (or just something like gitster+patch) that we can send\n> it to if we mean \"please include\" instead of \"what do you think of this\"?\n\nThe intention from regulars like you I can read from the tone of the\nmessage (or if you want to you can mention it in the log message).\n\nIf a clearer signal is really needed, perhaps we should say\nsomething like:\n\n    Send any patch that has not been reviewed on the list fist to\n    the list and area experts (you can learn who they are by running\n    \"git blame\" and \"git shortlog\" on the part of the system you are\n    touching) for review.  Once the patch gains list consensus that\n    it is a good change, and the maintainer hasn't picked it up\n    (perhaps it fell through cracks), resend it to the maintainer\n    with Cc: to the list.\n\nWe could phrase it more brutally:\n\n    If it is the first time a particular patch is sent to the list, it\n    almost always is not ready for inclusion.\n\nbut I do not think that is a good idea.\n"}]}