threads / discuss / 3574

any problems with new branch of gitk?

Subject: any problems with new branch of gitk?

## tl;dr

5 messages between Mar 5, 2006 and Mar 15, 2006.

replies: 4people: 3as markdown or json

Paul Mackerras· Mar 5, 2006, 22:09 UTC · lore

I'm planning to pull the `new' branch of the gitk repository into the master branch, making the new version of gitk the standard version that will go into the git.git repository. As far as I know the new version does everything the old version does. Does anyone know of any problems with the new gitk that weren't in the old one?

Thanks, Paul.

A Large Angry SCM· Mar 5, 2006, 23:16 UTC · re: Paul Mackerras · lore

Re: any problems with new branch of gitk?

Paul Mackerras wrote:

Show 5 quoted lines

> I'm planning to pull the `new' branch of the gitk repository into the
> master branch, making the new version of gitk the standard version
> that will go into the git.git repository.  As far as I know the new
> version does everything the old version does.  Does anyone know of any
> problems with the new gitk that weren't in the old one?

I don't know if the old version has this problem but the new version does not have a "busy" pointer while it's waiting for a merge diff. Take a look at the ACPI mega(octo)pus merge that happened in January.

Alex Riesen· Mar 6, 2006, 20:23 UTC · re: Paul Mackerras · lore

Re: any problems with new branch of gitk?

Paul Mackerras, Sun, Mar 05, 2006 23:09:17 +0100:

Show 5 quoted lines

> I'm planning to pull the `new' branch of the gitk repository into the
> master branch, making the new version of gitk the standard version
> that will go into the git.git repository.  As far as I know the new
> version does everything the old version does.  Does anyone know of any
> problems with the new gitk that weren't in the old one?

I don't if that was intended (see the screenshot attached), but some lines miss arrows. Click on where the arrow would be works (jump to counterpart arrow). Never have this with the old gitk.

Tcl/Tk 8.4.9 (Gentoo).

Paul Mackerras· Mar 15, 2006, 11:18 UTC · re: Alex Riesen · lore

Re: any problems with new branch of gitk?

Alex Riesen writes:

Show 5 quoted lines

> I don't if that was intended (see the screenshot attached), but some
> lines miss arrows. Click on where the arrow would be works (jump to
> counterpart arrow). Never have this with the old gitk.
> 
> Tcl/Tk 8.4.9 (Gentoo).

Yes, it seems that tk 8.4 can't draw arrows on the ends of diagonal line segments. The old gitk coped with this by simply shortening the line until it got to a vertical line segment. I can probably do better than that with the new layout algorithm. I'll look at it.

Paul.

Alex Riesen· Mar 15, 2006, 13:00 UTC · re: Paul Mackerras · lore

Re: any problems with new branch of gitk?

On 3/15/06, Paul Mackerras <paulus@samba.org> wrote:

Show 12 quoted lines

>
> > I don't if that was intended (see the screenshot attached), but some
> > lines miss arrows. Click on where the arrow would be works (jump to
> > counterpart arrow). Never have this with the old gitk.
> >
> > Tcl/Tk 8.4.9 (Gentoo).
>
> Yes, it seems that tk 8.4 can't draw arrows on the ends of diagonal
> line segments.  The old gitk coped with this by simply shortening the
> line until it got to a vertical line segment.  I can probably do
> better than that with the new layout algorithm.  I'll look at it.
>

Ok, thanks for confirmation. I wasn't sure if that's me, Gentoo, or tk.

On related note: do you know of any way to start gitk with sensible layout under cygwin? I ended up with commenting out sourcing of .gitk. It produces a window compressed in one block, which I can resize and relayout later. Any other attempt to preset the size or layout either can't be (literally) seen or can't be changed into something usable.