threads / patch / 34567

patchcontrib/subtree: Fix make install target

Subject: [PATCH] contrib/subtree: Fix make install target

## tl;dr

2 messages between Jul 30, 2013 and Jul 30, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Michal Sojka· Jul 30, 2013, 08:16 UTC · lore

If the libexec directory doesn't exist, git-subtree gets installed as $prefix/share/libexec/git-core file. This patch creates the directory before installing git-subtree file into it.

Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
---
 contrib/subtree/Makefile | 1 +
 1 file changed, 1 insertion(+)

Show changes to contrib/subtree/Makefile +1 −0

diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
index b507505..435b2de 100644
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -30,6 +30,7 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)
 doc: $(GIT_SUBTREE_DOC)
 
 install: $(GIT_SUBTREE)
+	$(INSTALL) -d -m 755 $(DESTDIR)$(libexecdir)
 	$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)
 
 install-doc: install-man

-- 
1.8.3.2

Junio C Hamano· Jul 30, 2013, 14:51 UTC · re: Michal Sojka · lore

Re: [PATCH] contrib/subtree: Fix make install target

Michal Sojka <sojkam1@fel.cvut.cz> writes:

Show 6 quoted lines

> If the libexec directory doesn't exist, git-subtree gets installed as
> $prefix/share/libexec/git-core file. This patch creates the directory
> before installing git-subtree file into it.
>
> Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
> ---

Will queue, as it is obviously correct.  Thanks.

I however wish somebody steps up to start properly maintaining this part of the contrib ;-).

Show 15 quoted lines

>  contrib/subtree/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index b507505..435b2de 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -30,6 +30,7 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)
>  doc: $(GIT_SUBTREE_DOC)
>  
>  install: $(GIT_SUBTREE)
> +	$(INSTALL) -d -m 755 $(DESTDIR)$(libexecdir)
>  	$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)
>  
>  install-doc: install-man