{"thread":{"id":"34567","subject":"[PATCH] contrib/subtree: Fix make install target","startedAt":"2013-07-30T08:16:09Z","lastAt":"2013-07-30T14:51:46Z","messageCount":2,"participants":["Michal Sojka","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"224285","messageId":"1375172169-26582-1-git-send-email-sojkam1@fel.cvut.cz","threadId":"34567","inReplyTo":null,"subject":"[PATCH] contrib/subtree: Fix make install target","fromName":"Michal Sojka","fromEmail":"sojkam1@fel.cvut.cz","sentAt":"2013-07-30T08:16:09Z","receivedAt":"2013-07-30T08:16:09Z","isPatch":true,"sender":{"key":"sojkam1@fel.cvut.cz","avatar":"https://avatars.githubusercontent.com/u/140542?v=4"},"body":"If the libexec directory doesn't exist, git-subtree gets installed as\n$prefix/share/libexec/git-core file. This patch creates the directory\nbefore installing git-subtree file into it.\n\nSigned-off-by: Michal Sojka <sojkam1@fel.cvut.cz>\n---\n contrib/subtree/Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex b507505..435b2de 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -30,6 +30,7 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)\n doc: $(GIT_SUBTREE_DOC)\n \n install: $(GIT_SUBTREE)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(libexecdir)\n \t$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)\n \n install-doc: install-man\n-- \n1.8.3.2\n"},{"id":"224296","messageId":"7vob9kxfr1.fsf@alter.siamese.dyndns.org","threadId":"34567","inReplyTo":"1375172169-26582-1-git-send-email-sojkam1@fel.cvut.cz","subject":"Re: [PATCH] contrib/subtree: Fix make install target","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-30T14:51:46Z","receivedAt":"2013-07-30T14:51:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michal Sojka <sojkam1@fel.cvut.cz> writes:\n\n> If the libexec directory doesn't exist, git-subtree gets installed as\n> $prefix/share/libexec/git-core file. This patch creates the directory\n> before installing git-subtree file into it.\n>\n> Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>\n> ---\n\nWill queue, as it is obviously correct.  Thanks.\n\nI however wish somebody steps up to start properly maintaining this\npart of the contrib ;-).\n\n>  contrib/subtree/Makefile | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\n> index b507505..435b2de 100644\n> --- a/contrib/subtree/Makefile\n> +++ b/contrib/subtree/Makefile\n> @@ -30,6 +30,7 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)\n>  doc: $(GIT_SUBTREE_DOC)\n>  \n>  install: $(GIT_SUBTREE)\n> +\t$(INSTALL) -d -m 755 $(DESTDIR)$(libexecdir)\n>  \t$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)\n>  \n>  install-doc: install-man\n"}]}