threads / patch / 34441

patchUse compat/regex on Cygwin

Subject: [PATCH] Use compat/regex on Cygwin

## tl;dr

4 messages between Jul 15, 2013 and Jul 16, 2013. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Mark Levedahl· Jul 15, 2013, 14:10 UTC · lore

Cygwin's regex library does not pass git's tests, so don't use it. This fixes failures in t4018 and t4034.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)

Show changes to config.mak.uname +1 −0

diff --git a/config.mak.uname b/config.mak.uname
index 7ac541e..6901597 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -165,6 +165,7 @@ ifeq ($(uname_O),Cygwin)
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
+	NO_REGEX = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient

-- 
1.8.3.2.0.13

Ramsay Jones· Jul 16, 2013, 21:41 UTC · re: Mark Levedahl · lore

Re: [PATCH] Use compat/regex on Cygwin

Mark Levedahl wrote:

> Cygwin's regex library does not pass git's tests, so don't use it. This
> fixes failures in t4018 and t4034.

Hmm, these tests have always passed for me on cygwin. So, this is presumably a regression in the new-lib regex library versions used by cygwin 1.5 and cygwin 1.7.

ATB, Ramsay Jones

Mark Levedahl· Jul 16, 2013, 22:03 UTC · re: Ramsay Jones · lore

Re: [PATCH] Use compat/regex on Cygwin

On 07/16/2013 05:41 PM, Ramsay Jones wrote:

Show 12 quoted lines

> Mark Levedahl wrote:
>> Cygwin's regex library does not pass git's tests, so don't use it. This
>> fixes failures in t4018 and t4034.
> Hmm, these tests have always passed for me on cygwin. So, this is
> presumably a regression in the new-lib regex library versions used
> by cygwin 1.5 and cygwin 1.7.
>
> ATB,
> Ramsay Jones
>
>
>

Perhaps we should just completely separate cygwin 1.5 settings from those for current cygwin. Extra motivation is that cygwin 1.5 is no longer on the mirrors - the last real update was mid 2009, and the project finally removed the installation tree altogether.

Mark

Mark Levedahl· Jul 16, 2013, 23:24 UTC · re: Ramsay Jones · lore

Re: [PATCH] Use compat/regex on Cygwin

On 07/16/2013 05:41 PM, Ramsay Jones wrote:

Show 12 quoted lines

> Mark Levedahl wrote:
>> Cygwin's regex library does not pass git's tests, so don't use it. This
>> fixes failures in t4018 and t4034.
> Hmm, these tests have always passed for me on cygwin. So, this is
> presumably a regression in the new-lib regex library versions used
> by cygwin 1.5 and cygwin 1.7.
>
> ATB,
> Ramsay Jones
>
>
>

Yes, cygwin 1.7 now uses the newlib regex functions, and those are not quite up to snuff. Another case for calling 1.5 a separate platform altogether.

Mark