{"thread":{"id":"34441","subject":"[PATCH] Use compat/regex on Cygwin","startedAt":"2013-07-15T14:10:53Z","lastAt":"2013-07-16T23:24:01Z","messageCount":4,"participants":["Mark Levedahl","Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"223430","messageId":"1373897453-18799-1-git-send-email-mlevedahl@gmail.com","threadId":"34441","inReplyTo":null,"subject":"[PATCH] Use compat/regex on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2013-07-15T14:10:53Z","receivedAt":"2013-07-15T14:10:53Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"Cygwin's regex library does not pass git's tests, so don't use it. This\nfixes failures in t4018 and t4034.\n\nSigned-off-by: Mark Levedahl <mlevedahl@gmail.com>\n---\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 7ac541e..6901597 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -165,6 +165,7 @@ ifeq ($(uname_O),Cygwin)\n \tNO_FAST_WORKING_DIRECTORY = UnfortunatelyYes\n \tNO_TRUSTABLE_FILEMODE = UnfortunatelyYes\n \tNO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease\n+\tNO_REGEX = UnfortunatelyYes\n \t# There are conflicting reports about this.\n \t# On some boxes NO_MMAP is needed, and not so elsewhere.\n \t# Try commenting this out if you suspect MMAP is more efficient\n-- \n1.8.3.2.0.13\n"},{"id":"223549","messageId":"51E5BE08.9060304@ramsay1.demon.co.uk","threadId":"34441","inReplyTo":"1373897453-18799-1-git-send-email-mlevedahl@gmail.com","subject":"Re: [PATCH] Use compat/regex on Cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-07-16T21:41:28Z","receivedAt":"2013-07-16T21:41:28Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Mark Levedahl wrote:\n> Cygwin's regex library does not pass git's tests, so don't use it. This\n> fixes failures in t4018 and t4034.\n\nHmm, these tests have always passed for me on cygwin. So, this is\npresumably a regression in the new-lib regex library versions used\nby cygwin 1.5 and cygwin 1.7.\n\nATB,\nRamsay Jones\n"},{"id":"223550","messageId":"51E5C322.80806@gmail.com","threadId":"34441","inReplyTo":"51E5BE08.9060304@ramsay1.demon.co.uk","subject":"Re: [PATCH] Use compat/regex on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2013-07-16T22:03:14Z","receivedAt":"2013-07-16T22:03:14Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"On 07/16/2013 05:41 PM, Ramsay Jones wrote:\n> Mark Levedahl wrote:\n>> Cygwin's regex library does not pass git's tests, so don't use it. This\n>> fixes failures in t4018 and t4034.\n> Hmm, these tests have always passed for me on cygwin. So, this is\n> presumably a regression in the new-lib regex library versions used\n> by cygwin 1.5 and cygwin 1.7.\n>\n> ATB,\n> Ramsay Jones\n>\n>\n>\nPerhaps we should just completely separate cygwin 1.5 settings from \nthose for current cygwin. Extra motivation is that cygwin 1.5 is no \nlonger on the mirrors - the last real update was mid 2009, and the \nproject finally removed the installation tree altogether.\n\nMark\n"},{"id":"223556","messageId":"51E5D611.7000300@gmail.com","threadId":"34441","inReplyTo":"51E5BE08.9060304@ramsay1.demon.co.uk","subject":"Re: [PATCH] Use compat/regex on Cygwin","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2013-07-16T23:24:01Z","receivedAt":"2013-07-16T23:24:01Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"On 07/16/2013 05:41 PM, Ramsay Jones wrote:\n> Mark Levedahl wrote:\n>> Cygwin's regex library does not pass git's tests, so don't use it. This\n>> fixes failures in t4018 and t4034.\n> Hmm, these tests have always passed for me on cygwin. So, this is\n> presumably a regression in the new-lib regex library versions used\n> by cygwin 1.5 and cygwin 1.7.\n>\n> ATB,\n> Ramsay Jones\n>\n>\n>\nYes, cygwin 1.7 now uses the newlib regex functions, and those are not \nquite up to snuff. Another case for calling 1.5 a separate platform \naltogether.\n\nMark\n"}]}