threads / patch / 33990

patchtest: fix post rewrite hook report

Subject: [PATCH] test: fix post rewrite hook report

## tl;dr

2 messages between May 30, 2013 and May 30, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Felipe Contreras· May 30, 2013, 13:46 UTC · lore
First expected, then actual.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t5407-post-rewrite-hook.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to t/t5407-post-rewrite-hook.sh +2 −2
diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
index baa670c..ea2e0d4 100755
--- a/t/t5407-post-rewrite-hook.sh
+++ b/t/t5407-post-rewrite-hook.sh
@@ -31,8 +31,8 @@ clear_hook_input () {
 }
 
 verify_hook_input () {
-	test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
-	test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
+	test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
+	test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
 }
 
 test_expect_success 'git commit --amend' '
-- 
1.8.3.rc3.312.g47657de
Thomas Rast· May 30, 2013, 14:35 UTC · re: Felipe Contreras · lore

Re: [PATCH] test: fix post rewrite hook report

Felipe Contreras <felipe.contreras@gmail.com> writes:
> First expected, then actual.
Ack.  That is the prevalent (almost universal, but not quite) style.
Show 20 quoted lines
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  t/t5407-post-rewrite-hook.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
> index baa670c..ea2e0d4 100755
> --- a/t/t5407-post-rewrite-hook.sh
> +++ b/t/t5407-post-rewrite-hook.sh
> @@ -31,8 +31,8 @@ clear_hook_input () {
>  }
>  
>  verify_hook_input () {
> -	test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
> -	test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
> +	test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
> +	test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
>  }
>  
>  test_expect_success 'git commit --amend' '
-- 
Thomas Rast
trast@{inf,student}.ethz.ch

← back to recent threads