# [PATCH] test: fix post rewrite hook report 2 messages from 2013-05-30 to 2013-05-30. Participants: Felipe Contreras, Thomas Rast. Thread: https://gitlist.dev/t/33990 ## Felipe Contreras, 2013-05-30 13:46 Subject: [PATCH] test: fix post rewrite hook report Message-ID: <1369921595-30514-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1369921595-30514-1-git-send-email-felipe.contreras%40gmail.com ``` First expected, then actual. Signed-off-by: Felipe Contreras --- t/t5407-post-rewrite-hook.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh index baa670c..ea2e0d4 100755 --- a/t/t5407-post-rewrite-hook.sh +++ b/t/t5407-post-rewrite-hook.sh @@ -31,8 +31,8 @@ clear_hook_input () { } verify_hook_input () { - test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args && - test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data + test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args && + test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data } test_expect_success 'git commit --amend' ' -- 1.8.3.rc3.312.g47657de ``` ## Thomas Rast, 2013-05-30 14:35 Subject: Re: [PATCH] test: fix post rewrite hook report Message-ID: <87d2s8fscu.fsf@linux-k42r.v.cablecom.net> URL: https://gitlist.dev/e/87d2s8fscu.fsf%40linux-k42r.v.cablecom.net In-Reply-To: <1369921595-30514-1-git-send-email-felipe.contreras@gmail.com> ``` Felipe Contreras writes: > First expected, then actual. Ack. That is the prevalent (almost universal, but not quite) style. > Signed-off-by: Felipe Contreras > --- > t/t5407-post-rewrite-hook.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh > index baa670c..ea2e0d4 100755 > --- a/t/t5407-post-rewrite-hook.sh > +++ b/t/t5407-post-rewrite-hook.sh > @@ -31,8 +31,8 @@ clear_hook_input () { > } > > verify_hook_input () { > - test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args && > - test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data > + test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args && > + test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data > } > > test_expect_success 'git commit --amend' ' -- Thomas Rast trast@{inf,student}.ethz.ch ```