threads / patch / 33763

v3, 5 partsallow more sources for config values

Subject: [PATCH v3 0/5] allow more sources for config values

## tl;dr

3 messages between May 9, 2013 and May 9, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Heiko Voigt· May 9, 2013, 16:16 UTC · lore
Hi,
I fixed all the issues I know of so this should be ready for master.
This is an update with the comments of the second iteration[1] incorporated.
[1] http://thread.gmane.org/gmane.comp.version-control.git/217811
Heiko Voigt (5):
  config: factor out config file stack management
  config: drop cf validity check in get_next_char()
  config: make parsing stack struct independent from actual data source
  teach config --blob option to parse config from database
  do not die when error in config parsing of buf occurs
 builtin/config.c       |  39 +++++++--
 cache.h                |   6 +-
 config.c               | 216 ++++++++++++++++++++++++++++++++++++++-----------
 t/t1307-config-blob.sh |  75 +++++++++++++++++
 4 files changed, 281 insertions(+), 55 deletions(-)
 create mode 100755 t/t1307-config-blob.sh
-- 
1.8.3.rc1.40.gba374ae
Junio C Hamano· May 9, 2013, 21:00 UTC · re: Heiko Voigt · lore

Re: [PATCH v3 0/5] allow more sources for config values

Heiko Voigt <hvoigt@hvoigt.net> writes:
> I fixed all the issues I know of so this should be ready for master.

Thanks for working on thsi, but that is 'master after 1.8.3' at this point in the release cycle.

I am declaring patch bankruptcy and will not be picking up new patches that are not regression fixes meant for 1.8.3 or subsystem updates to my tree. I am mildly upset that nobody (including myself) caught the show-stopper regression to cherry-pick, even though it has been on 'master' for more than 20 days.

Please do continue discussing this and other patches on the list, and please do plan to re-submit after dust settles post 1.8.3 release.

Thanks.
Jeff King· May 9, 2013, 22:41 UTC · re: Heiko Voigt · lore

Re: [PATCH v3 0/5] allow more sources for config values

On Thu, May 09, 2013 at 06:16:36PM +0200, Heiko Voigt wrote:
Show 10 quoted lines
> This is an update with the comments of the second iteration[1] incorporated.
> 
> [1] http://thread.gmane.org/gmane.comp.version-control.git/217811
> 
> Heiko Voigt (5):
>   config: factor out config file stack management
>   config: drop cf validity check in get_next_char()
>   config: make parsing stack struct independent from actual data source
>   teach config --blob option to parse config from database
>   do not die when error in config parsing of buf occurs
Thanks, I think it looks good except for a few minor things I mentioned.
-Peff

← back to recent threads