{"thread":{"id":"33763","subject":"[PATCH v3 0/5] allow more sources for config values","startedAt":"2013-05-09T16:16:36Z","lastAt":"2013-05-09T22:41:25Z","messageCount":3,"participants":["Heiko Voigt","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":3,"patchTotal":5},"messages":[{"id":"216778","messageId":"20130509161636.GB3526@book-mint","threadId":"33763","inReplyTo":null,"subject":"[PATCH v3 0/5] allow more sources for config values","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2013-05-09T16:16:36Z","receivedAt":"2013-05-09T16:16:36Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Hi,\n\nI fixed all the issues I know of so this should be ready for master.\n\nThis is an update with the comments of the second iteration[1] incorporated.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/217811\n\nHeiko Voigt (5):\n  config: factor out config file stack management\n  config: drop cf validity check in get_next_char()\n  config: make parsing stack struct independent from actual data source\n  teach config --blob option to parse config from database\n  do not die when error in config parsing of buf occurs\n\n builtin/config.c       |  39 +++++++--\n cache.h                |   6 +-\n config.c               | 216 ++++++++++++++++++++++++++++++++++++++-----------\n t/t1307-config-blob.sh |  75 +++++++++++++++++\n 4 files changed, 281 insertions(+), 55 deletions(-)\n create mode 100755 t/t1307-config-blob.sh\n\n-- \n1.8.3.rc1.40.gba374ae\n"},{"id":"216816","messageId":"7vk3n798cy.fsf@alter.siamese.dyndns.org","threadId":"33763","inReplyTo":"20130509161636.GB3526@book-mint","subject":"Re: [PATCH v3 0/5] allow more sources for config values","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-09T21:00:29Z","receivedAt":"2013-05-09T21:00:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Heiko Voigt <hvoigt@hvoigt.net> writes:\n\n> I fixed all the issues I know of so this should be ready for master.\n\nThanks for working on thsi, but that is 'master after 1.8.3' at this\npoint in the release cycle.\n\nI am declaring patch bankruptcy and will not be picking up new\npatches that are not regression fixes meant for 1.8.3 or subsystem\nupdates to my tree.  I am mildly upset that nobody (including\nmyself) caught the show-stopper regression to cherry-pick, even\nthough it has been on 'master' for more than 20 days.\n\nPlease do continue discussing this and other patches on the list,\nand please do plan to re-submit after dust settles post 1.8.3\nrelease.\n\nThanks.\n"},{"id":"216826","messageId":"20130509224124.GD30774@sigill.intra.peff.net","threadId":"33763","inReplyTo":"20130509161636.GB3526@book-mint","subject":"Re: [PATCH v3 0/5] allow more sources for config values","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-05-09T22:41:25Z","receivedAt":"2013-05-09T22:41:25Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, May 09, 2013 at 06:16:36PM +0200, Heiko Voigt wrote:\n\n> This is an update with the comments of the second iteration[1] incorporated.\n> \n> [1] http://thread.gmane.org/gmane.comp.version-control.git/217811\n> \n> Heiko Voigt (5):\n>   config: factor out config file stack management\n>   config: drop cf validity check in get_next_char()\n>   config: make parsing stack struct independent from actual data source\n>   teach config --blob option to parse config from database\n>   do not die when error in config parsing of buf occurs\n\nThanks, I think it looks good except for a few minor things I mentioned.\n\n-Peff\n"}]}