threads / patch / 33616

patch, 5 partstest-hg-bidi.sh: do not use export X=Y

Subject: [PATCH 3/5] test-hg-bidi.sh: do not use export X=Y

## tl;dr

One message between Apr 26, 2013 and Apr 26, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Torsten Bögershausen· Apr 26, 2013, 09:17 UTC · lore

The shell syntax "export X=Y A=B" is not understood by all shells. Split the non portable line into separate lines like this: A=B X=Y export A X

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 contrib/remote-helpers/test-hg-bidi.sh | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Show changes to contrib/remote-helpers/test-hg-bidi.sh +6 −5
diff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh
index f368953..f569697 100755
--- a/contrib/remote-helpers/test-hg-bidi.sh
+++ b/contrib/remote-helpers/test-hg-bidi.sh
@@ -68,10 +68,10 @@ setup () {
 	) >> "$HOME"/.hgrc &&
 	git config --global remote-hg.hg-git-compat true
 
-	export HGEDITOR=/usr/bin/true
-
-	export GIT_AUTHOR_DATE="2007-01-01 00:00:00 +0230"
-	export GIT_COMMITTER_DATE="$GIT_AUTHOR_DATE"
+	HGEDITOR=/usr/bin/true
+	GIT_AUTHOR_DATE="2007-01-01 00:00:00 +0230"
+	GIT_COMMITTER_DATE="$GIT_AUTHOR_DATE"
+	export HGEDITOR GIT_AUTHOR_DATE GIT_COMMITTER_DATE
 }
 
 setup
@@ -88,7 +88,8 @@ test_expect_success 'encoding' '
 	git add alpha &&
 	git commit -m "add älphà" &&
 
-	export GIT_AUTHOR_NAME="tést èncödîng" &&
+	GIT_AUTHOR_NAME="tést èncödîng" &&
+	export GIT_AUTHOR_NAME &&
 	echo beta > beta &&
 	git add beta &&
 	git commit -m "add beta" &&
-- 
1.8.2.1.614.g66d7af5

← back to recent threads