{"thread":{"id":"33616","subject":"[PATCH 3/5] test-hg-bidi.sh: do not use export X=Y","startedAt":"2013-04-26T09:17:56Z","lastAt":"2013-04-26T09:17:56Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"215578","messageId":"201304261117.57010.tboegi@web.de","threadId":"33616","inReplyTo":null,"subject":"[PATCH 3/5] test-hg-bidi.sh: do not use export X=Y","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-26T09:17:56Z","receivedAt":"2013-04-26T09:17:56Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"The shell syntax \"export X=Y A=B\" is not understood by all shells.\nSplit the non portable line into separate lines like this:\nA=B\nX=Y\nexport A X\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n contrib/remote-helpers/test-hg-bidi.sh | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)\n\ndiff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh\nindex f368953..f569697 100755\n--- a/contrib/remote-helpers/test-hg-bidi.sh\n+++ b/contrib/remote-helpers/test-hg-bidi.sh\n@@ -68,10 +68,10 @@ setup () {\n \t) >> \"$HOME\"/.hgrc &&\n \tgit config --global remote-hg.hg-git-compat true\n \n-\texport HGEDITOR=/usr/bin/true\n-\n-\texport GIT_AUTHOR_DATE=\"2007-01-01 00:00:00 +0230\"\n-\texport GIT_COMMITTER_DATE=\"$GIT_AUTHOR_DATE\"\n+\tHGEDITOR=/usr/bin/true\n+\tGIT_AUTHOR_DATE=\"2007-01-01 00:00:00 +0230\"\n+\tGIT_COMMITTER_DATE=\"$GIT_AUTHOR_DATE\"\n+\texport HGEDITOR GIT_AUTHOR_DATE GIT_COMMITTER_DATE\n }\n \n setup\n@@ -88,7 +88,8 @@ test_expect_success 'encoding' '\n \tgit add alpha &&\n \tgit commit -m \"add älphà\" &&\n \n-\texport GIT_AUTHOR_NAME=\"tést èncödîng\" &&\n+\tGIT_AUTHOR_NAME=\"tést èncödîng\" &&\n+\texport GIT_AUTHOR_NAME &&\n \techo beta > beta &&\n \tgit add beta &&\n \tgit commit -m \"add beta\" &&\n-- \n1.8.2.1.614.g66d7af5\n"}]}