threads / patch / 33415

v2remote-helpers/test-bzr.sh: do not use grep \s

Subject: [PATCH V2] remote-helpers/test-bzr.sh: do not use grep \s

## tl;dr

One message between Apr 7, 2013 and Apr 7, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Torsten Bögershausen· Apr 7, 2013, 09:23 UTC · lore

Using grep "devel\s\+3:" to find at least one whitespace is not portable on all grep versions: Not all grep versions understand "\s" as a "whitespace".

The + as a qualifier for "one or more" is not a basic regular expression: use egrep instead of grep. Use a literal TAB followed by SPACE like this [ ] instead, which is more portable than [:space:]

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 contrib/remote-helpers/test-hg.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to contrib/remote-helpers/test-hg.sh +1 −1
diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
index 5f81dfa..7bb81f2 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '
   git push
   ) &&
 
-  hg -R hgrepo bookmarks | grep "devel\s\+3:"
+  hg -R hgrepo bookmarks | egrep "devel[	 ]+3:"
 '
 
 test_done
-- 
1.8.2.341.g543621f

← back to recent threads