{"thread":{"id":"33415","subject":"[PATCH V2] remote-helpers/test-bzr.sh: do not use grep \\s","startedAt":"2013-04-07T09:23:30Z","lastAt":"2013-04-07T09:23:30Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"213400","messageId":"201304071123.31602.tboegi@web.de","threadId":"33415","inReplyTo":null,"subject":"[PATCH V2] remote-helpers/test-bzr.sh: do not use grep \\s","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-07T09:23:30Z","receivedAt":"2013-04-07T09:23:30Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Using grep \"devel\\s\\+3:\" to find at least one whitespace\nis not portable on all grep versions:\nNot all grep versions understand \"\\s\" as a \"whitespace\".\n\nThe + as a qualifier for \"one or more\" is not a basic regular expression:\nuse egrep instead of grep.\nUse a literal TAB followed by SPACE like this [\t ] instead,\nwhich is more portable than [:space:] \n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n contrib/remote-helpers/test-hg.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh\nindex 5f81dfa..7bb81f2 100755\n--- a/contrib/remote-helpers/test-hg.sh\n+++ b/contrib/remote-helpers/test-hg.sh\n@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '\n   git push\n   ) &&\n \n-  hg -R hgrepo bookmarks | grep \"devel\\s\\+3:\"\n+  hg -R hgrepo bookmarks | egrep \"devel[\t ]+3:\"\n '\n \n test_done\n-- \n1.8.2.341.g543621f\n"}]}