threads / discuss / 33188

SSH version on Git 1.8.1.2 for Windows is outdated.

Subject: SSH version on Git 1.8.1.2 for Windows is outdated.

## tl;dr

6 messages between Mar 15, 2013 and Mar 16, 2013.

replies: 5people: 5as markdown or json

Kristof Mattei· Mar 15, 2013, 10:05 UTC · lore

We're having issues with the version of SSH included in git version 1.8.1.msysgit.1 (Git-1.8.1.2-preview20130201.exe)

The included version of SSH is from 2007:

C:\Program Files (x86)\Git\bin - Old>ssh -V OpenSSH_4.6p1, OpenSSL 0.9.8e 23 Feb 2007

Updating the OpenSSH component (downloaded with Cygwin, cumbersome!!!) resolves the issue:

C:\Program Files (x86)\Git\bin>ssh -V OpenSSH_6.1p1, OpenSSL 1.0.1e 11 Feb 2013

Is there any way you can incorporate this update in the installer?
Thanks,

-Kristof -- Kristof Mattei Human Compiler

Blog: www.kristofmattei.be
Twitter: KristofMattei
Konstantin Khomoutov· Mar 15, 2013, 17:03 UTC · re: Kristof Mattei · lore

Re: SSH version on Git 1.8.1.2 for Windows is outdated.

On Fri, 15 Mar 2013 11:05:11 +0100 Kristof Mattei <kristof@kristofmattei.be> wrote:

Show 15 quoted lines
> We're having issues with the version of SSH included in git version
> 1.8.1.msysgit.1 (Git-1.8.1.2-preview20130201.exe)
> 
> The included version of SSH is from 2007:
> 
> C:\Program Files (x86)\Git\bin - Old>ssh -V
> OpenSSH_4.6p1, OpenSSL 0.9.8e 23 Feb 2007
> 
> Updating the OpenSSH component (downloaded with Cygwin, cumbersome!!!)
> resolves the issue:
> 
> C:\Program Files (x86)\Git\bin>ssh -V
> OpenSSH_6.1p1, OpenSSL 1.0.1e 11 Feb 2013
> 
> Is there any way you can incorporate this update in the installer?

Yes, you should grab the msysGit (the Git for Windows build environment) [2], tweak it to include the new OpenSSH binary, ensure it builds and works OK and then send a pull request (or post your patchset to the msysgit mailing list [3].

A sort of crash course on how to get started is [1]. The main page for the msysGit/Git for Windows development is [4].

Note that there should be no Cygwin involved, of course. Git for Windows is built completely from the sources of all the components it includes, using MinGW/MSYS so no component of Git for Windows depends on the Cygwin runtime DLL.

1. https://github.com/msysgit/msysgit/issues/102#issuecomment-13572331
2. http://github.com/msysgit/msysgit
3. http://groups.google.com/group/msysgit
4. http://msysgit.github.com/
Joshua Jensen· Mar 15, 2013, 20:11 UTC · re: Konstantin Khomoutov · lore

Re: SSH version on Git 1.8.1.2 for Windows is outdated.

----- Original Message -----
From: Konstantin Khomoutov
Date: 3/15/2013 11:03 AM
Show 12 quoted lines
> On Fri, 15 Mar 2013 11:05:11 +0100
> Kristof Mattei <kristof@kristofmattei.be> wrote:
>
>> C:\Program Files (x86)\Git\bin>ssh -V
>> OpenSSH_6.1p1, OpenSSL 1.0.1e 11 Feb 2013
>>
>> Is there any way you can incorporate this update in the installer?
> Yes, you should grab the msysGit (the Git for Windows build
> environment) [2], tweak it to include the new OpenSSH binary, ensure it
> builds and works OK and then send a pull request (or post your patchset
> to the msysgit mailing list [3].
>
Wow, we can do that now?

When I brought up the vastly improved performance from a newer SSH executable, I was told the only way to get it in would be to build from source [1].

-Josh

[1] https://groups.google.com/forum/?fromgroups=#!searchin/msysgit/ssh$20josh/msysgit/U3InWruEl88/TAFaw4xJUI0J

Sebastian Schuberth· Mar 16, 2013, 13:14 UTC · re: Joshua Jensen · lore

Re: SSH version on Git 1.8.1.2 for Windows is outdated.

On 15.03.2013 21:11, Joshua Jensen wrote:
Show 10 quoted lines
>> Yes, you should grab the msysGit (the Git for Windows build
>> environment) [2], tweak it to include the new OpenSSH binary, ensure it
>> builds and works OK and then send a pull request (or post your patchset
>> to the msysgit mailing list [3].
>>
> Wow, we can do that now?
>
> When I brought up the vastly improved performance from a newer SSH
> executable, I was told the only way to get it in would be to build from
> source [1].

"tweak it to include the new OpenSSH binary" is supposed to include the step to adjust the release.sh script to grab the updated sources and build the binary.

However, another option is to take a look at the new mingwGitDevEnv project [1], which relies on mingw-get to retrieve binary packages. I hopefully find soon the time to include OpenSSH 6.1p1 incl. HPN-SSH patches [2].

[1] https://github.com/sschuberth/mingwGitDevEnv [2] https://github.com/sschuberth/mingwGitDevEnv/pull/5

-- 
Sebastian Schuberth
Patrik Gornicz· Mar 16, 2013, 20:49 UTC · re: Sebastian Schuberth · lore

Re: SSH version on Git 1.8.1.2 for Windows is outdated.

On 03/16/13 09:14, Sebastian Schuberth wrote:
Show 16 quoted lines
> On 15.03.2013 21:11, Joshua Jensen wrote:
>
>>> Yes, you should grab the msysGit (the Git for Windows build
>>> environment) [2], tweak it to include the new OpenSSH binary, ensure it
>>> builds and works OK and then send a pull request (or post your patchset
>>> to the msysgit mailing list [3].
>>>
>> Wow, we can do that now?
>>
>> When I brought up the vastly improved performance from a newer SSH
>> executable, I was told the only way to get it in would be to build from
>> source [1].
>
> "tweak it to include the new OpenSSH binary" is supposed to include the
> step to adjust the release.sh script to grab the updated sources and
> build the binary.

I attempted to do just this about a month ago though things really started to snowball. To get openssh to compile you need to update a bunch of other programs in the msys branch and I just lost interest in doing so. More info can be found in the msysgit issue "Upgrade SSH" [1].

> However, another option is to take a look at the new mingwGitDevEnv
> project [1], which relies on mingw-get to retrieve binary packages. I
> hopefully find soon the time to include OpenSSH 6.1p1 incl. HPN-SSH
> patches [2].

Any idea as to when this mingwGitDevEnv project will be mature enough to use as a replacement for msysgit? One of the reasons I gave up trying to tweak things to get openssh compiling was that this seemed like a much better idea. Though if it's fair off I might find time to give it another shot.

> [1] https://github.com/sschuberth/mingwGitDevEnv
> [2] https://github.com/sschuberth/mingwGitDevEnv/pull/5

If someone is keen to try and update openssh in msysgit I'd be willing to share my hacks from a month ago which could be used as a starting point. It was left nowhere near ready for a pull request, partially due to binary issues mentioned above, but at least it'll provide reasonable ideas to a few of the things that need to happen.

[1] https://github.com/msysgit/msysgit/issues/31
Patrik
Sebastian Schuberth· Mar 16, 2013, 20:54 UTC · re: Patrik Gornicz · lore

Re: SSH version on Git 1.8.1.2 for Windows is outdated.

On Sat, Mar 16, 2013 at 9:49 PM, Patrik Gornicz <patrik-git@mail.pgornicz.com> wrote:

> Any idea as to when this mingwGitDevEnv project will be mature enough to use
> as a replacement for msysgit? One of the reasons I gave up trying to tweak

Due to a lack of contributors this is taking longer than I anticipated. But I realize I need to make contributing easier, and also find the time to merge some outstanding pull requests. I hope to be able to make some significant improvements at the end of March.

-- 
Sebastian Schuberth

← back to recent threads